chore: remove deprecated wasmedge_llmc plugin (#36) by 0yi0 · Pull Request #51 · WasmEdge/cpp-plugins · GitHub
Skip to content

chore: remove deprecated wasmedge_llmc plugin (#36)#51

Draft
0yi0 wants to merge 1 commit into
mainfrom
36-remove-llmc
Draft

chore: remove deprecated wasmedge_llmc plugin (#36)#51
0yi0 wants to merge 1 commit into
mainfrom
36-remove-llmc

Conversation

@0yi0

@0yi0 0yi0 commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

PR summary

Remove the wasmedge_llmc plugin. Upstream deprecated it (WasmEdge/WasmEdge#4964, chore(plugin/llmc): deprecate wasmedge-llmc plugin); rather than migrate it into cpp-plugins, we drop it. Closes #36 (the llmc migration issue). Decision flagged in #36 / #22.

Implementation design

  • git rm -r plugins/wasmedge_llmc test/plugins/wasmedge_llmc
  • Remove the if(WASMEDGE_PLUGIN_LLMC) add_subdirectory(wasmedge_llmc) stanza from plugins/CMakeLists.txt and test/plugins/CMakeLists.txt.
  • libpiper is intentionally untouched — it belongs to wasi_nn (utils/wasi-nn/, utils/build_libpiper.sh), not llmc.

Design decisions

  • Removal, not deprecation-carry: cpp-plugins shouldn't ship a plugin upstream is dropping.
  • Verified no dangling references remain (wasmedge_llmc / WASMEDGE_PLUGIN_LLMC / wasmedgePluginWasmEdgeLLMC all gone).

Commit slicing

Single authored commit: chore: remove deprecated wasmedge_llmc plugin (#36).

Test plan

  • No remaining wasmedge_llmc / WASMEDGE_PLUGIN_LLMC references in the tree
  • libpiper / wasi_nn files intact
  • clang-format (clang-format-22, ci: adopt WasmEdge clang-format lint method (#45) #49 method) passes — exit 0
  • CI: clang-format / super-linter / commitlint expected green; DCO green (single signed commit, author == sign-off)

Interaction with #50 (re-import)

#50 (the faithful refresh re-import) modifies test/plugins/wasmedge_llmc (it carries the upstream deprecation commit), while this PR deletes that dir. Recommended merge order: #50 first (keep the mirror faithful), then this removal as the clean follow-up. If this merges first, #50 needs a trivial modify/delete resolution (keep the deletion).

Non-goals / afterwards


🤖 Generated by Claude Opus 4.8 (1M context) with Claude Code

Upstream deprecated the wasmedge_llmc plugin (WasmEdge/WasmEdge#4964).
Rather than migrate it into cpp-plugins, remove it: drop
plugins/wasmedge_llmc and test/plugins/wasmedge_llmc and their
add_subdirectory stanzas in plugins/CMakeLists.txt and
test/plugins/CMakeLists.txt. libpiper (wasi_nn) is unrelated and kept.

Closes #36

Signed-off-by: Yi Huang <yi@secondstate.io>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: migrate wasmedge_llmc

1 participant