• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Summary of Changes

This PR fixes a bug (ISXB-1713) where the "Add Control Scheme Device Type" UI element would unexpectedly close when autosave was triggered in the Input Actions Editor window. The fix works by preventing autosave in InputActionsEditorWindow.cs and InputActionsEditorSettingsProvider.cs when the ControlSchemesView is active for that specific editor instance. A new IsControlSchemeViewActive() method was added to InputActionsEditorView.cs to facilitate this check.

Risk Assessment

• High Risk Areas: None identified.
• Medium Risk Areas:
  • Potential for autosave not triggering when it should, if the IsControlSchemeViewActive() check is overly broad or incorrect.
  • The fix does not fully resolve the issue for Project Wide Actions (PWA) opened via Project Settings, as noted in the PR comments.
• Low Risk Areas:
  • Minor changes to Debug.LogWarning message.
  • Leftover debugging logs and a TODO comment in the PR code are noted as needing removal before merge, but don't pose functional risk.

Functional Testing

• Verify Fix (Standalone Editor Window):
  1. Create a new Input Action Asset.
  2. Open it in a standalone Input Actions Editor Window.
  3. Add an Action Map and an Action.
  4. Go to the "Control Schemes" tab.
  5. Click the '+' button to add a new control scheme.
  6. In the new control scheme, click '+' next to 'Device Type' to open the "Add Control Scheme Device Type" popup.
  7. Make a change that would typically trigger autosave (e.g., click outside the popup to dirty the asset, but keep the popup focused).
  8. Expected: The "Add Control Scheme Device Type" popup remains open and does not close due to autosave.
• Verify Known Limitation (Project Wide Actions in Project Settings):
  1. Open "Project Settings" -> "Input System Package".
  2. Ensure a Project Wide Actions (PWA) asset is selected or create one.
  3. Make some changes to dirty the asset (Project Settings always uses autosave).
  4. Go to the "Control Schemes" tab.
  5. Click the '+' button to add a new control scheme.
  6. In the new control scheme, click '+' next to 'Device Type' to open the "Add Control Scheme Device Type" popup.
  7. Make a change that would typically trigger autosave (e.g., just navigate around in the editor window).
  8. Expected: The "Add Control Scheme Device Type" popup will still close unexpectedly. (This confirms the known limitation from Pauliusd01's comment).
• Autosave Functionality (General):
  1. Create an Input Action Asset.
  2. Open it in the Input Actions Editor Window.
  3. Make a change (e.g., add an action).
  4. Close the window or unfocus Unity to trigger autosave.
  5. Re-open the asset.
  6. Expected: The changes are saved correctly, and autosave functions as expected when the control scheme UI is not active.

Regression Testing

• Manual Save Functionality:
  1. Open an Input Action Asset in the editor.
  2. Make changes.
  3. Manually save the asset (Ctrl+S or File -> Save).
  4. Expected: Changes are saved, and no errors occur.
• Multiple Editor Windows:
  1. Open two different Input Action Assets in two separate Input Actions Editor Windows.
  2. In one window, open the "Add Control Scheme Device Type" popup.
  3. In the other window, make a change to trigger autosave.
  4. Expected: The autosave in the second window completes successfully without closing the popup in the first window.
• Autosave Disabled:
  1. Disable autosave for Input Action Assets in project settings.
  2. Replicate the steps for "Verify Fix (Standalone Editor Window)".
  3. Expected: The "Add Control Scheme Device Type" popup remains open, and no autosave attempts are made (as expected when autosave is disabled).