{{ message }}
[HDRP] Disable volumetric clouds in lens flare sample indoor scene #6953
Merged
Conversation
sebastienlagarde
approved these changes
Feb 2, 2022
sebastienlagarde
pushed a commit
that referenced
this pull request
Feb 2, 2022
sebastienlagarde
added a commit
that referenced
this pull request
Feb 2, 2022
* Changed the roughness value used for screen space reflections and ray traced reflections to match environment lighting (case 1390916). #680 * [HDRP] Improve custom pass name UI #6859 * Fixed using the wrong directional light data for clouds and the definition of current Sun when the shadow pass is culled (case 1399000) #6925 * [HDRP] Disable volumetric clouds in lens flare sample indoor scene #6953 * [Hdrp] Merge Hd/bugfix #6954 * Update HDAdditionalLightData.cs Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: Rémi Chapelain <57442369+remi-chapelain@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Following this PR, the same fix is needed for the lens flare indoor sample scene.
Testing status
Switched between scenes (outdoor, indoor) with and without always refresh. ✔️
Comments to reviewers
Needs backport 2021.2 and need to check after backport that the volume has the proper override since we had issue with backport for the indoor template scenes