{{ message }}
[RPW][1386964]Fix undo for DebugUI.Enum fields on the rendering debugger.#6632
Merged
Conversation
arttu-peltonen
approved these changes
Dec 16, 2021
arttu-peltonen
left a comment
arttu-peltonen
left a comment
Contributor
There was a problem hiding this comment.
Another enum index issue :) nice work!
JulienIgnace-Unity
approved these changes
Dec 16, 2021
alex-vazquez
changed the title
JMargevics
approved these changes
Jan 10, 2022
JMargevics
left a comment
JMargevics
left a comment
Contributor
There was a problem hiding this comment.
Find a semi-related issue of UI not playing nicely when changing multiple enum fields but undoing only once. Reported it.
Otherwise undoing enum fields does work correctly now and Undo history shows correct names. All good from my side 🟢👍
Contributor
|
PR seems to miss some doc but otherwise ready to go? |
Contributor
Author
sebastienlagarde
pushed a commit
that referenced
this pull request
Feb 1, 2022
sebastienlagarde
added a commit
that referenced
this pull request
Feb 1, 2022
* fixed typo and made style guide fixes (#6749) * style guide fixes (#6750) * Added menu trail to change atlas resolution (#6755) * Clarified how to find hdrp in package manager (#6756) * made style guide fixes (#6762) * added new instructions for photoshop colour channels (#6769) * made naming of AO consistent (#6771) * Removed reference to 3d with extras project (#6781) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added default value (#6770) * Added default value * Fixed merge issue * undo wrong fix Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Merge Hd/bugfix #6791 * Fix warning on baking set renaming #6808 * Renamed the Exposure field to Exposure Compensation in sky volume overrides (case 1392530). #6801 * Refresh baking set scene list when one baking set is removed. #6811 * clarified how to change mode (#6871) * fixed screenshot annotation colour (#6872) * fixed formatting (#6873) * fixed name of Game view (#6874) * fixed note formatting (#6875) * new screenshot and fixed table formatting (#6889) * minor style guide changes (#6904) * remove italics, note formatting (#6906) * fixed typo "on following GPUs" > on the following GPUs (#6909) * Post Process can now be edited in the default frame settings. #6816 * Fixed errors spamming when in player mode due to ray tracing light cluster debug view (case 1390471). #6820 * Fixed missing unit in ray tracing related tooltips and docs (case 1397491). #6822 * [Fogbugz # 1386436] Fixing FPTL failing when near and far are very tight. #6826 * Fixed an issue where forced sky update would not update ambient probe. #6831 * Fixed a null ref exception in Volume Explorer #6834 * Cleaning up FPTL early out for ps4 and PC (#6882) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix static sky lighting update when render textures are updated #6863 * Quality update of custom post process (#6856) * Disable the clouds in the indoor sample scenes (normal and DXR) #6908 * Fixed using the wrong coordinate to compute the sampling direction for the screen space global illumination. #6903 * Update VolumeParameter.cs * Replaced view lighting tool with light anchor (#6829) * Replaced view lighting tool with light anchor * Update View-Lighting-Tool.md * Apply formatting changes * revert: Fix cached directional shadows disappearing when going out of shadow range to never reappear #6802 * [RPW][1386964]Fix undo for DebugUI.Enum fields on the rendering debugger. #6632 * More explicit error message when trying to use Shader Graph nodes HDSceneColor, NormalFromHeight, DDX, DDY or DDXY in ray tracing #6254 * [RPW]Fix recovering the correct index for DebugUI.Enum field that are not autoenum (#6901) * Proper Indoors scene template volume * Update 004-CloudsFlaresDecals.png Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Rémi Chapelain <remi.chapelain@unity3d.com>
sebastienlagarde
added a commit
that referenced
this pull request
Feb 1, 2022
* fixed typo and made style guide fixes (#6749) * style guide fixes (#6750) * Added menu trail to change atlas resolution (#6755) * Clarified how to find hdrp in package manager (#6756) * made style guide fixes (#6762) * added new instructions for photoshop colour channels (#6769) * made naming of AO consistent (#6771) * Removed reference to 3d with extras project (#6781) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added default value (#6770) * Added default value * Fixed merge issue * undo wrong fix Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Merge Hd/bugfix #6791 * Fix warning on baking set renaming #6808 * Renamed the Exposure field to Exposure Compensation in sky volume overrides (case 1392530). #6801 * Refresh baking set scene list when one baking set is removed. #6811 * clarified how to change mode (#6871) * fixed screenshot annotation colour (#6872) * fixed formatting (#6873) * fixed name of Game view (#6874) * fixed note formatting (#6875) * new screenshot and fixed table formatting (#6889) * minor style guide changes (#6904) * remove italics, note formatting (#6906) * fixed typo "on following GPUs" > on the following GPUs (#6909) * Post Process can now be edited in the default frame settings. #6816 * Fixed errors spamming when in player mode due to ray tracing light cluster debug view (case 1390471). #6820 * Fixed missing unit in ray tracing related tooltips and docs (case 1397491). #6822 * [Fogbugz # 1386436] Fixing FPTL failing when near and far are very tight. #6826 * Fixed an issue where forced sky update would not update ambient probe. #6831 * Fixed a null ref exception in Volume Explorer #6834 * Cleaning up FPTL early out for ps4 and PC (#6882) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix static sky lighting update when render textures are updated #6863 * Quality update of custom post process (#6856) * Disable the clouds in the indoor sample scenes (normal and DXR) #6908 * Fixed using the wrong coordinate to compute the sampling direction for the screen space global illumination. #6903 * Update VolumeParameter.cs * Replaced view lighting tool with light anchor (#6829) * Replaced view lighting tool with light anchor * Update View-Lighting-Tool.md * Apply formatting changes * revert: Fix cached directional shadows disappearing when going out of shadow range to never reappear #6802 * [RPW][1386964]Fix undo for DebugUI.Enum fields on the rendering debugger. #6632 * More explicit error message when trying to use Shader Graph nodes HDSceneColor, NormalFromHeight, DDX, DDY or DDXY in ray tracing #6254 * [RPW]Fix recovering the correct index for DebugUI.Enum field that are not autoenum (#6901) * Proper Indoors scene template volume * Update 004-CloudsFlaresDecals.png Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Rémi Chapelain <remi.chapelain@unity3d.com>
sebastienlagarde
added a commit
that referenced
this pull request
Feb 1, 2022
* [HDRP 21.2] Backport various PRs (#6926) * fixed typo and made style guide fixes (#6749) * style guide fixes (#6750) * Added menu trail to change atlas resolution (#6755) * Clarified how to find hdrp in package manager (#6756) * made style guide fixes (#6762) * added new instructions for photoshop colour channels (#6769) * made naming of AO consistent (#6771) * Removed reference to 3d with extras project (#6781) Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Added default value (#6770) * Added default value * Fixed merge issue * undo wrong fix Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * Merge Hd/bugfix #6791 * Fix warning on baking set renaming #6808 * Renamed the Exposure field to Exposure Compensation in sky volume overrides (case 1392530). #6801 * Refresh baking set scene list when one baking set is removed. #6811 * clarified how to change mode (#6871) * fixed screenshot annotation colour (#6872) * fixed formatting (#6873) * fixed name of Game view (#6874) * fixed note formatting (#6875) * new screenshot and fixed table formatting (#6889) * minor style guide changes (#6904) * remove italics, note formatting (#6906) * fixed typo "on following GPUs" > on the following GPUs (#6909) * Post Process can now be edited in the default frame settings. #6816 * Fixed errors spamming when in player mode due to ray tracing light cluster debug view (case 1390471). #6820 * Fixed missing unit in ray tracing related tooltips and docs (case 1397491). #6822 * [Fogbugz # 1386436] Fixing FPTL failing when near and far are very tight. #6826 * Fixed an issue where forced sky update would not update ambient probe. #6831 * Fixed a null ref exception in Volume Explorer #6834 * Cleaning up FPTL early out for ps4 and PC (#6882) * Changelog Co-authored-by: sebastienlagarde <sebastien@unity3d.com> * [HDRP] Fix static sky lighting update when render textures are updated #6863 * Quality update of custom post process (#6856) * Disable the clouds in the indoor sample scenes (normal and DXR) #6908 * Fixed using the wrong coordinate to compute the sampling direction for the screen space global illumination. #6903 * Update VolumeParameter.cs * Replaced view lighting tool with light anchor (#6829) * Replaced view lighting tool with light anchor * Update View-Lighting-Tool.md * Apply formatting changes * revert: Fix cached directional shadows disappearing when going out of shadow range to never reappear #6802 * [RPW][1386964]Fix undo for DebugUI.Enum fields on the rendering debugger. #6632 * More explicit error message when trying to use Shader Graph nodes HDSceneColor, NormalFromHeight, DDX, DDY or DDXY in ray tracing #6254 * [RPW]Fix recovering the correct index for DebugUI.Enum field that are not autoenum (#6901) * Proper Indoors scene template volume * Update 004-CloudsFlaresDecals.png Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Rémi Chapelain <remi.chapelain@unity3d.com> * Fixed missing capital and UI bolding (#6876) * [RPW]Fix Diffusion Profile Volume Component inspector when opened wit… #6799 * Disabled the "Reflect Sky" feature in the case of transparent screenspace reflections for the water system. #6725 Co-authored-by: emilybrown1 <88374601+emilybrown1@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com> Co-authored-by: anisunity <42026998+anisunity@users.noreply.github.com> Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: Kleber Garcia <kleber.garcia@unity3d.com> Co-authored-by: Antoine Lelievre <antoinel@unity3d.com> Co-authored-by: noreply@unity3d.com <noreply@unity3d.com> Co-authored-by: alex-vazquez <76204843+alex-vazquez@users.noreply.github.com> Co-authored-by: Emmanuel Turquin <emmanuel@turquin.org> Co-authored-by: Rémi Chapelain <remi.chapelain@unity3d.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix https://fogbugz.unity3d.com/f/cases/1386964/
Testing status
Test that Undo/Redo is working for Enum fields on the rendering debugger.
Comments to reviewers
Serialization issue, the index where not being correctly set for enum fields after a serialization.