{{ message }}
Automatically enable Alpha-To-Coverage when alpha clipping is on#6599
Merged
Conversation
adrien-de-tocqueville
changed the title
remi-chapelain
left a comment
remi-chapelain
left a comment
Contributor
There was a problem hiding this comment.
Good idea in general and I agree it's also good to align on what URP does.
I'm for deleting reference of it in the editor, but it can still be interesting to note it in the doc that we use this method / algorithm by default in the MSAA / Alpha Clipping docs just for the sake of it because it was implemented recently-ish (1 year ago)
remi-chapelain
approved these changes
Dec 14, 2021
remi-chapelain
left a comment
remi-chapelain
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me.
Feature has been tested and tests are still passing ✔️
sebastienlagarde
approved these changes
Dec 16, 2021
adrien-de-tocqueville
added a commit
that referenced
this pull request
Jan 6, 2022
sebastienlagarde
pushed a commit
that referenced
this pull request
Jan 13, 2022
* Reenable "Automatically enable Alpha-To-Coverage when alpha clipping is on (#6599)" * Workaround shadow bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Removed the alpha to coverage option on material and shadergraphs, it will now be always enabled in forward msaa when alpha clipping is on.
URP will do it like that with #6312 and it's actually a good idea since the performance cost is minimal and it removes a shader variant. Also it's much simpler to setup because not a lot of users know about this option
There was also a frame setting to enable/disable alpha to coverage per camera. I also removed it, but maybe there can be an interest in keeping it.
I removed every mention of alpha to coverage in the docs, and search all occurence of alphatocoverage in code to make sure i removed everything.
NOTE: i'll have to mention the change in what's new if we want to merge
Testing status
There are two tests 9402 that test alpha to coverage with regular shaders and shadergraphs, they don't change with this PR
Tested that in deferred, and forward without msaa there is no issue.
Yamato looks green
Comments to reviewers
Notes for the reviewers you have assigned.