[ANT-302] Replace s10s with s21s by theopnv · Pull Request #6408 · Unity-Technologies/Graphics · GitHub
Skip to content

[ANT-302] Replace s10s with s21s#6408

Merged
theopnv merged 4 commits into
masterfrom
ant/urp/android/use-s21
Nov 29, 2021
Merged

[ANT-302] Replace s10s with s21s#6408
theopnv merged 4 commits into
masterfrom
ant/urp/android/use-s21

Conversation

@theopnv

@theopnv theopnv commented Nov 26, 2021

Copy link
Copy Markdown
Contributor

Purpose of this PR

https://jira.unity3d.com/browse/ANT-302

  • Compare results with nightly from same base commit + List findings in this document

Testing status

@github-actions github-actions Bot added the sdet label Nov 26, 2021
@theopnv

theopnv commented Nov 29, 2021

Copy link
Copy Markdown
Contributor Author

Comment thread .yamato/_abv.yml Outdated
@theopnv theopnv marked this pull request as ready for review November 29, 2021 10:05
@theopnv theopnv requested a review from a team as a code owner November 29, 2021 10:05
@theopnv theopnv requested a review from tomzig16 November 29, 2021 10:05
@theopnv theopnv merged commit b5156f1 into master Nov 29, 2021
@theopnv theopnv deleted the ant/urp/android/use-s21 branch November 29, 2021 12:55
theopnv pushed a commit that referenced this pull request Nov 30, 2021
@theopnv theopnv mentioned this pull request Nov 30, 2021
theopnv pushed a commit that referenced this pull request Nov 30, 2021
@theopnv theopnv mentioned this pull request Nov 30, 2021
theopnv pushed a commit that referenced this pull request Dec 1, 2021
theopnv pushed a commit that referenced this pull request Dec 1, 2021
@theopnv

theopnv commented Jan 3, 2022

Copy link
Copy Markdown
Contributor Author

I'm planning the backports for this PR, and realized on 10xx and 7xx we are still using hikeys (I think), since we're using Unity::mobile::android. Is that intenteded/is it planed to replace these with samsung devices (S21s?) @tomzig16

@tomzig16

tomzig16 commented Jan 3, 2022

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants