{{ message }}
Small Fix for Vortex subgraph addition#6332
Merged
Merged
Conversation
# Conflicts: # com.unity.visualeffectgraph/CHANGELOG.md
PaulDemeulenaere
approved these changes
Jan 3, 2022
PaulDemeulenaere
left a comment
PaulDemeulenaere
left a comment
There was a problem hiding this comment.
The actual change is minimal, however, the sugraphblock embedded in additionnal will probably deserve attention. I'm involving @Unity-Technologies/gfx-qa-vfx for visibility.
VladNeykov
approved these changes
Jan 4, 2022
VladNeykov
left a comment
VladNeykov
left a comment
Contributor
There was a problem hiding this comment.
Minimal change on a VFX sample; no additional testing required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Small fix that prevents NaNs in Subgraph block Vortex (included in VFX Additions)
Testing status
N/A
Comments to reviewers
N/A