{{ message }}
Make USE_DRAW_PROCEDURAL variation only for vertex programs in UberPost shader#6260
Merged
phi-lira merged 5 commits intoNov 18, 2021
Merged
Conversation
phi-lira
reviewed
Nov 10, 2021
This change was done only for shaders inside PostProcessing folder
phi-lira
approved these changes
Nov 18, 2021
phi-lira
force-pushed
the
universal/staging
branch
from
096b400 to
027aa06
Compare
This was referenced Nov 18, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR fixes https://fogbugz.unity3d.com/f/cases/1377405/
UberPost has a lot of fragment shader variants that use _USE_DRAW_PROCEDURAL. In fact, removing this keyword (again, only in fragment shaders) with the URP template project reduced its number of variants from 1279 to 639 in 2020.3.18. The change reduces the shader's memory usage from ~12MB to ~6MB. So this PR simply makes _USE_DRAW_PROCEDURAL compile only for vertex shaders by changing its declaration in UberPost shader from
#pragma multi_compileto#pragma multi_compile_vertex.Testing status
Manually looked if results are visually correct and affected (before and after change) in URP Post Processing project + editor
Yamato tests on Post Processing and XR
Comments to reviewers
OSX Metal test fails on master branch with 137 error code.