Fixed SetPerCameraShaderVariables function not working as expected by thomas-zeng · Pull Request #6249 · Unity-Technologies/Graphics · GitHub
Skip to content

Fixed SetPerCameraShaderVariables function not working as expected#6249

Merged
phi-lira merged 5 commits into
universal/stagingfrom
universal/xr/fix-percam-shadervar-urp
Nov 18, 2021
Merged

Fixed SetPerCameraShaderVariables function not working as expected#6249
phi-lira merged 5 commits into
universal/stagingfrom
universal/xr/fix-percam-shadervar-urp

Conversation

@thomas-zeng

@thomas-zeng thomas-zeng commented Nov 8, 2021

Copy link
Copy Markdown
Contributor

PR is second iteration of #6114
Shader Graph team had already approved the other iteration.


Purpose of this PR

  • This PR fixed an issue where _ScreenParams set by SetPerCameraShaderVariables are getting reset.

Testing status

  • Tested with local project that disaplays _ScreenParams.xy value on quad.
  • ABV

Comments to reviewers

@thomas-zeng thomas-zeng requested a review from a team as a code owner November 8, 2021 15:55
@thomas-zeng thomas-zeng requested a review from a team November 8, 2021 15:55
@github-actions

github-actions Bot commented Nov 8, 2021

Copy link
Copy Markdown

@thomas-zeng thomas-zeng requested a review from a team as a code owner November 9, 2021 08:50
@phi-lira phi-lira changed the base branch from universal/staging to master November 10, 2021 09:30
@phi-lira phi-lira force-pushed the universal/xr/fix-percam-shadervar-urp branch from 8da6abb to e619900 Compare November 10, 2021 09:34
@phi-lira phi-lira changed the base branch from master to universal/staging November 10, 2021 09:36
@phi-lira phi-lira merged commit 3a6c4a1 into universal/staging Nov 18, 2021
@phi-lira phi-lira deleted the universal/xr/fix-percam-shadervar-urp branch November 18, 2021 17:17
This was referenced Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants