{{ message }}
Enables per node includes on the DecalPass.template#6245
Merged
phi-lira merged 1 commit intoNov 10, 2021
Merged
Conversation
This is necasary for custom functions and some other nodes
Jonasmortensen
changed the title
lukaschod
approved these changes
Nov 8, 2021
phi-lira
approved these changes
Nov 10, 2021
phi-lira
deleted the
universal/bugfix/missing-includes-in-decal-target
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This line is also in the ShaderPass.template used by the other URP targets.
Without it, custom function nodes referencing a file cannot be used with the decal target.
The PR also fixes procedural shadergraph nodes (like simple noise) not compiling when used with the decal target. Reason being that the required include was not being included.