{{ message }}
[HDRP][Backport 21.2] Backport various PRs#6231
Merged
Merged
Conversation
When using particular types of upscaling, (CAS, FSR, Catmull) the film grain quality produced by HDRP was lower than expected. This was caused by errors in the UV scale calculations for the grain texture. This change fixes the issue by modifying the scale calculations to use the final viewport size rather than the size of the current scaled/unscaled viewport. This works because film grain is always handled by "FinalPass" which always renders at final viewport size anyways. This change also fixes a few cases where the current resolution group would have been incorrect when CAS or FSR were being used as the upscaling method.
Co-authored-by: Sean Puller <sean.puller@unity3d.com>
* Initial commit MRP implementation * Barn door application * Add dominant marschner lobe direction skeleton * Finalize rect light MRP for marschner, handle forward + backward hemisphere scattering. * Force pathtracer to far-field in case users use geometry with bad normals. * com.unity.render-pipelines.high-definition/Runtime/Material/Hair/MultipleScattering/HairMultipleScattering.hlsl * Fix SH ringing for multiple scattering * Add trivial support for cookies * Add Kajiya support for area light approximation (non-LTC) * remove Line area light MRP for now * Remove area rect reference * Update area light hair test scene and reference images * Select cookie mip based on solid angle, rename some functions, temporarily add back rect ref * Remove the useless div-by-1 and add a comment to explain the removal of the divide by PI * Add a comment to further explain the normalization we do on the longitudinal distribution * Remove the ref once again * Update test images for metal and vulkan * Add a zero-div guard to silence compiler warning
* Fixed grammar errors * fixed passive voice in decal doc * Update Decal.md * Update Decal.md * Update Decal.md
… removed in #9d6db83478c213bc066e5f728d94b7faa6662543 (#6104)
* updated fog override screenshot * changed Depth Extent to Volumetric Fog Distance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Purpose of this PR
Testing status
Describe what manual/automated tests were performed for this PR
Comments to reviewers
Notes for the reviewers you have assigned.