2d/analytics by sebastienlagarde · Pull Request #6227 · Unity-Technologies/Graphics · GitHub
Skip to content

2d/analytics#6227

Closed
sebastienlagarde wants to merge 596 commits into
masterfrom
2d/Analytics
Closed

2d/analytics#6227
sebastienlagarde wants to merge 596 commits into
masterfrom
2d/Analytics

Conversation

@sebastienlagarde

@sebastienlagarde sebastienlagarde commented Nov 5, 2021

Copy link
Copy Markdown
Contributor

Please read the Contributing guide before making a PR.

Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR. If you do add documentation, make sure to add the relevant Graphics Docs team member as a reviewer of the PR. If you are not sure which person to add, see the Docs team contacts sheet.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Purpose of this PR

Why is this PR needed, what hard problem is it solving/fixing?

Testing status

Describe what manual/automated tests were performed for this PR

Comments to reviewers

Notes for the reviewers you have assigned.

phi-lira and others added 30 commits February 28, 2019 16:47
@phi-lira
Fixed Post and VR.
81ebc0d
@phi-lira
Made cameraHandles private, exposed ConfigureCameraTarget to ser cam…
372afae 
…era target handles instead.
@phi-lira
udpated custom lw pipeline
8110da7
@Verasl
Nicer clean spin Scriptable renderer
a7aaa38
@phi-lira
Fixed issue that cause game view to not render if no objects were re…
8a8cede 
…ndering and clearing backgroud to solid color.
@rainsing
Merge branch 'lw/passes-in-objects' into 2d/render-setup
9e59a91
@unity-cchu
Moved some of the text into Styles.
66ac060
@rainsing
Merge branch '2d/render-setup' of https://github.com/Unity-Technologi…
3844522 
…es/ScriptableRenderPipeline into 2d/render-setup
@unity-cchu
Made point light gizmo more consistant. Renamed hard to understand me…
7447e2f 
…mbers
@unity-cchu
Merge branch '2d/render-setup' of https://github.com/Unity-Technologi…
a5dd13e 
…es/ScriptableRenderPipeline into 2d/render-setup
@Verasl
Fixed bug with removing pass and merged layermasks on forward renderer
6bd9049
@phi-lira
Changed AddRenderPass api to pass renderingData (it contains cameraT…
d220f35 
…argetDescriptor) and to remove camera color and depth target as ScriptableRenderer has it. This lays out work for CameraStacking.
@unity-cchu
Changed some of the function names to be more readable
bc3d252
@unity-cchu
Renamed a textures used by the editor. Fixed some more naming issues …
5e40559 
…in Light2DEditor
@unity-cchu
replaced lt with light
bb95b12
@Verasl
Code clean up
9f39f46 
- fixed namespace issue when making list of render features
- cleaned up LWRP asset UI
@phi-lira
Fixed issues caused by last commit. Now boat attack and all tests ar…
3dd28ca 
…e passing.
@phi-lira
Merge branch 'master' into lw/passes-in-objects
0082133 
# Conflicts:
#	TestProjects/LWGraphicsTest/Assets/Scenes/007_LitShaderMaps.unity
#	TestProjects/LWGraphicsTest/Assets/Scenes/045_CustomLWPipe/CustomRenderGraph.asset
#	TestProjects/LWGraphicsTest/Assets/Scenes/045_CustomLWPipe/CustomRenderGraph.asset.meta
#	TestProjects/LWGraphicsTest/ProjectSettings/EditorBuildSettings.asset
#	com.unity.testing.srp.lightweight/Tests/Scenes/007_LitShaderMaps/LightingData.asset
#	com.unity.testing.srp.lightweight/Tests/Scenes/045_CustomLWPipe/CustomRenderGraph.asset
#	com.unity.testing.srp.lightweight/Tests/Scenes/045_CustomLWPipe/CustomRenderGraph.asset.meta
#	com.unity.testing.srp.lightweight/Tests/Scenes/045_CustomLWPipe/CustomRenderer.asset
#	com.unity.testing.srp.lightweight/Tests/Scenes/045_CustomLWPipe/CustomRenderer.asset.meta
@Verasl
Update ScriptableRendererDataEditor.cs
16bc06f 
Updated tooltip
@Katstodian
Update CHANGELOG.md
35e1f09 
Docs reciew of changelog.md
@rainsing
Rearranged the fields in Light2DShape.cs.
6d93ae6
@rainsing
Merge branch 'lw/passes-in-objects' into 2d/render-setup
894fd11
@rainsing
Fixes after merge.
2b1b862
@unity-cchu
Fixed clamping issue on point light
c7eed28
@unity-cchu
Merge branch '2d/render-setup' of https://github.com/Unity-Technologi…
15c2d00 
…es/ScriptableRenderPipeline into 2d/render-setup
@unity-cchu
Parametric shapes now draw their outlines
3d95c95
@phi-lira
update api
c4258c1
@unity-cchu
Fixed parametric mesh to support falloff offset and offset correctly
a812236
@unity-cchu
Removed offset from freeform as it doesn't really work with freeform …
3fe9df8 
…editor
@unity-cchu
Removed unnecessary indent levels
3c82842
rainsing and others added 25 commits April 24, 2019 14:03
@rainsing
There're more cases where we need to use an offscreen render texture.
991ba38
@rainsing
Merge branch '2d/render-setup' of https://github.com/Unity-Technologi…
1fa8022 
…es/ScriptableRenderPipeline into 2d/render-setup
@unity-cchu
Changed light overlap mode to alpha blend on overlap
3d0f371
@unity-cchu
Merge branch '2d/render-setup' of https://github.com/Unity-Technologi…
abc12b8 
…es/ScriptableRenderPipeline into 2d/render-setup
@unity-cchu
Added inner outline to freeform lights that can be seen outside edit …
e569b15 
…mode
@rainsing
Fixed the shape editor button.
989ac8e
@unity-cchu
Updated scene view icons
fd3206e
@unity-cchu
Merge branch '2d/render-setup' of https://github.com/Unity-Technologi…
5aa2898 
…es/ScriptableRenderPipeline into 2d/render-setup
@rainsing
Fixed issues related to global light in prefab editing mode.
adefc6a
@rainsing
Merge branch '2d/render-setup' of https://github.com/Unity-Technologi…
8209ac1 
…es/ScriptableRenderPipeline into 2d/render-setup
@rainsing
Properly check if it's a global light before calling AddGlobalLight()…
f063789 
… in Light2D.color and Light2D.intensity.
@rainsing
Removed the global color from Light Operation. It now defaults to bla…
b7de42f 
…ck if there's no global light.
@rainsing
Merge branch 'master' into 2d/render-setup
db32020
@rainsing
Reverted unnecessary changes.
8602402
@rainsing
Reverted test project package manifest.
dbbed43
@rainsing
Merged changes from 2d/render-setup.
a3c5fd4
@rainsing
Renamed "light operation" to "blend style".
b99f1bc
@unity-cchu
In progress analytics instrumenting
4f17adc
@unity-cchu
Merge branch '2d/render-setup' into 2d/Analytics
f238b9c
@unity-cchu
Deconflicted merge
096ae20
@unity-cchu
Fixed remaining merge issues
a69b969
@unity-cchu
Updated some of the analytics tracking and data structures
a6a27d3
@unity-cchu
Update Analytics.cs
87a541c 
Minor consistancy change
@unity-cchu
Enabled the analytics code and fixed issues
1f54441
@unity-cchu
Clean up analytics code. Renamed a few files. Fixed spacing in menus
60d9491
@sebastienlagarde sebastienlagarde marked this pull request as ready for review November 5, 2021 16:16
@sebastienlagarde sebastienlagarde requested a review from a team as a code owner November 5, 2021 16:16
@github-actions

github-actions Bot commented Nov 5, 2021

Copy link
Copy Markdown

@sebastienlagarde sebastienlagarde deleted the 2d/Analytics branch November 5, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sebastienlagarde @phi-lira @Verasl @rainsing @unity-cchu @Katstodian