{{ message }}
[SRP] Fix issue when changing volume profiles at runtime with a script#5882
Merged
Conversation
JulienIgnace-Unity
approved these changes
Oct 4, 2021
remi-chapelain
approved these changes
Oct 5, 2021
remi-chapelain
left a comment
remi-chapelain
left a comment
Contributor
There was a problem hiding this comment.
Fix makes sense and testing seems sufficient given the specific use case. ✔️
sebastienlagarde
approved these changes
Nov 4, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
https://fogbugz.unity3d.com/f/cases/1364256/
Some volume components of a volume profile can be destroyed externally (for example by the editor when exiting play mode, if they were created at runtime). In this PR I have added a method to check and remove the "zombies".
Testing status
I have tested using the repro scene. The nullref error does not repro anymore after my change.