{{ message }}
[HDRP] Fix spot shadow sampling when using custom spot angle#5439
Merged
Conversation
added 2 commits
August 25, 2021 19:14
…n 'custom spot angle'
sebastienlagarde
approved these changes
Aug 25, 2021
FrancescoC-unity
approved these changes
Aug 26, 2021
RemyUnity
approved these changes
Aug 31, 2021
RemyUnity
left a comment
RemyUnity
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for the screenshots 🟢
Merged
sebastienlagarde
added
needs-backport-2021.2
backported-2021.2
backported-10.x
and removed
needs-backport-2021.2
needs-backport-10.x
labels
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Fix an issue regarding the shadow map sampling of spotlights with the custom spot angle option enabled
https://forum.unity.com/threads/custom-shadow-angle-for-spot-light-having-wrong-wrap-mode.1139824/
Testing status
Checked that there is no more shadow leaking from the side of the shadow map:
Before:
After:
I also tested the pyramid spot light shape
https://yamato.cds.internal.unity3d.com/jobs/902-Graphics/tree/hd%252Ffix%252Fspot-shadow-sampling/.yamato%252Fall-hdrp.yml%2523PR_HDRP_trunk/8370632/job