Bugfix 1358480: Fixed missing tooltip for "Tessellation Mode"#5365
Conversation
remi-chapelain
left a comment
There was a problem hiding this comment.
While this technically fixes the issue indeed. I feel like this does not help users a lot, especially since it's not self explanatory which option does what.
What do you think of adding two quick lines (summed up from documentation) to help users a bit more here ?
"Specifies the method HDRP uses to tessellate the mesh.
None only use Displacement Map to tessellate the mesh.
Phong tessellation applies vertex interpolation to make geometry smoother."
|
I don't know how much of the documentation is usually pulled to tooltips. The problem I see is the maintenance, i.e. if options are removed/added, then in addition to the docs the tooltips needs to be updated as well to reflect the change, which I guess is easy to miss. How is this with other dropdown menus? |
|
The best answer I can give is, it depends :). Some dropdown tooltips are brief when it's self explanatory and some are way longer. I personally prefer having a longer tooltip as soon as I consider there can be confusion or questioning for the user as to what these select options do. And it saves lots of time searching for details in the documentation. As for your concerns about maintenance, I would say, @Unity-Technologies/gfx-qa-hdrp is already very sensitive about tooltips. HDRP is already not easy to learn, better take all our chances :) Here's a few example from materials and overrides: |





Purpose of this PR
Fixed missing tooltip for "Tessellation Mode"
Testing status
Tested the tooltip shows in editor
Comments to reviewers
The original Fogbugz case: https://fogbugz.unity3d.com/f/cases/1358480/