Bugfix 1358480: Fixed missing tooltip for "Tessellation Mode" by JarkkoUnity · Pull Request #5365 · Unity-Technologies/Graphics · GitHub
Skip to content

Bugfix 1358480: Fixed missing tooltip for "Tessellation Mode"#5365

Merged
sebastienlagarde merged 4 commits into
hd/bugfixfrom
hd/bugfix-1358480
Aug 24, 2021
Merged

Bugfix 1358480: Fixed missing tooltip for "Tessellation Mode"#5365
sebastienlagarde merged 4 commits into
hd/bugfixfrom
hd/bugfix-1358480

Conversation

@JarkkoUnity

Copy link
Copy Markdown
Contributor

Purpose of this PR

Fixed missing tooltip for "Tessellation Mode"


Testing status

Tested the tooltip shows in editor


Comments to reviewers

The original Fogbugz case: https://fogbugz.unity3d.com/f/cases/1358480/

@JarkkoUnity JarkkoUnity changed the base branch from master to hd/bugfix August 17, 2021 12:47
@github-actions

Copy link
Copy Markdown

@github-actions github-actions Bot added the HDRP label Aug 17, 2021
@JarkkoUnity JarkkoUnity marked this pull request as ready for review August 18, 2021 12:06
@JarkkoUnity JarkkoUnity requested a review from a team August 18, 2021 12:10

@remi-chapelain remi-chapelain left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this technically fixes the issue indeed. I feel like this does not help users a lot, especially since it's not self explanatory which option does what.

What do you think of adding two quick lines (summed up from documentation) to help users a bit more here ?

"Specifies the method HDRP uses to tessellate the mesh.
None only use Displacement Map to tessellate the mesh.
Phong tessellation applies vertex interpolation to make geometry smoother."

image

@JarkkoUnity

Copy link
Copy Markdown
Contributor Author

I don't know how much of the documentation is usually pulled to tooltips. The problem I see is the maintenance, i.e. if options are removed/added, then in addition to the docs the tooltips needs to be updated as well to reflect the change, which I guess is easy to miss. How is this with other dropdown menus?

@remi-chapelain

remi-chapelain commented Aug 23, 2021

Copy link
Copy Markdown
Contributor

The best answer I can give is, it depends :). Some dropdown tooltips are brief when it's self explanatory and some are way longer.

I personally prefer having a longer tooltip as soon as I consider there can be confusion or questioning for the user as to what these select options do. And it saves lots of time searching for details in the documentation.

As for your concerns about maintenance, I would say, @Unity-Technologies/gfx-qa-hdrp is already very sensitive about tooltips. HDRP is already not easy to learn, better take all our chances :)

Here's a few example from materials and overrides:

Double Sided GI
image

Global Illumination
image

Reflections Tracing mode
image

@JarkkoUnity

Copy link
Copy Markdown
Contributor Author

@remi-chapelain remi-chapelain self-requested a review August 23, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants