{{ message }}
Fix incorrect additional velocity for alembic#5304
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
When using additional velocity from Alembic, if we try to combine it with vertex animation inside the shader graph it was giving an incorrect result. With this fix, vertex animation and alembic velocity can be combine correctly.
Testing status
This have been tested in the context of this PR
https://github.com/Unity-Technologies/Graphics/pull/4931/files
Fix is separated as it need to be backported
a new graphic test will be added for this case as well as custom velocity in a next pr
Comments to reviewers
Notes for the reviewers you have assigned.