{{ message }}
Fix for discrepancies in saturation and intensity between screen space refraction and probe refraction#4653
Merged
Conversation
iM0ve
approved these changes
May 26, 2021
iM0ve
left a comment
iM0ve
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the test showcase. Minor code change, looks good.
sebastienlagarde
approved these changes
May 26, 2021
Contributor
There was a problem hiding this comment.
can you check we don't have the same issue in stacklit (iirc stacklit support refraction?)
Contributor
Author
There was a problem hiding this comment.
Nope, looks like it is not supported
phocodes
approved these changes
May 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for https://fogbugz.unity3d.com/f/cases/1325298/
The probe version had an additional multiply by the transmittance, it was in https://github.com/Unity-Technologies/Graphics/pull/4653/files#diff-c0279e9ca5f2c9c431c0e83cefb9445734a2f0cbf08e2e3ad5208edb96ff70d9L2004 and https://github.com/Unity-Technologies/Graphics/pull/4653/files#diff-c0279e9ca5f2c9c431c0e83cefb9445734a2f0cbf08e2e3ad5208edb96ff70d9L2017 (removed)
This fixes the most glaring discrepancies. There are still some but are due to different source content and convolution methods to get the output for a given roughness.
Before:
refrDiscr_0.mp4
After:
refrDiscr_1.mp4
I think this will change a lot of screenshots, but given I understood yamato is not in a good state now I didn't re-run. We'd need to to not have red tests.
What did I test: repro and can see what I did in video.