Disable clear coat UI. by eh-unity · Pull Request #1320 · Unity-Technologies/Graphics · GitHub
Skip to content

Disable clear coat UI.#1320

Merged
phi-lira merged 1 commit into
masterfrom
universal/disable-clearcoat
Jul 17, 2020
Merged

Disable clear coat UI.#1320
phi-lira merged 1 commit into
masterfrom
universal/disable-clearcoat

Conversation

@eh-unity

Copy link
Copy Markdown
Contributor

Purpose of this PR

Temporarily disable clear coat UI for internal change reasons.


Checklist for PR maker

  • Have you added a backport label (if needed)? For example, the need-backport-* label. After you backport the PR, the label changes to backported-*.
  • Have you updated the changelog? Each package has a CHANGELOG.md file.
  • Have you updated or added the documentation for your PR? When you add a new feature, change a property name, or change the behavior of a feature, it's best practice to include related documentation changes in the same PR.
  • Have you added a graphic test for your PR (if needed)? When you add a new feature, or discover a bug that tests don't cover, please add a graphic test.

Testing status

Manual Tests: What did you do?

  • Opened test project + Run graphic tests locally
  • Built a player
  • Checked new UI names with UX convention
  • Tested UI multi-edition + Undo/Redo + Prefab overrides + Alignment in Preset
  • C# and shader warnings (supress shader cache to see them)
  • Checked new resources path for the reloader (in developer mode, you have a button at end of resources that check the paths)
  • Other:

Automated Tests: What did you setup? (Add a screenshot or the reference image of the test please)

Yamato: (Select your branch):
https://yamato.prd.cds.internal.unity3d.com/jobs/902-Graphics

Any test projects to go with this to help reviewers?


Comments to reviewers

Notes for the reviewers you have assigned.

@eh-unity eh-unity requested a review from phi-lira July 17, 2020 08:30
@eh-unity eh-unity marked this pull request as ready for review July 17, 2020 08:58
@eh-unity eh-unity requested a review from a team as a code owner July 17, 2020 08:58
@eh-unity

Copy link
Copy Markdown
Contributor Author

@phi-lira phi-lira merged commit 28f1686 into master Jul 17, 2020
@phi-lira phi-lira deleted the universal/disable-clearcoat branch July 17, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants