{{ message }}
to_raster: handle unset extent; accept singleton extra dims#1420
Merged
Conversation
… and returns that 1D view.
Contributor
Author
Member
rajeeja
force-pushed
the
rajeeja/fix_issue1393
branch
from
64602f1 to
e8c5198
Compare
rajeeja
changed the title
erogluorhan
reviewed
Dec 17, 2025
erogluorhan
left a comment
erogluorhan
left a comment
Member
There was a problem hiding this comment.
This is looking great and almost there; please see my comments below.
Cartopy can set projection limits while autoscale stays on, so the old (0,1)-only check missed default extents. Using autoscale plus a global PlateCarree extent keeps the warning firing when users never set an extent.
…array into rajeeja/fix_issue1393
erogluorhan
approved these changes
Dec 19, 2025
erogluorhan
left a comment
erogluorhan
left a comment
Member
There was a problem hiding this comment.
Looks good to me! Please fix the link-check and merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @brianpm for reporting #1393. This PR fixes #1393 that axes extent must be set before calling to_raster, and fixes the flat-output issue by auto-detecting default axes limits and setting a reasonable extent from grid lon/lat bounds when needed (with a warning). It also adds support for data with extra length-1 dimensions by allowing singleton dims and squeezing to (n_face,) before rasterization.