{{ message }}
Curl#1389
Merged
Merged
Conversation
- Add test_curl_comprehensive.py with extensive curl test coverage - Update curl.ipynb following divergence notebook pattern - Remove separate test_curl.py and test_gradient.py files - All curl functionality tested and working
- Resolved conflicts in docs/userguide.rst to include both curl and divergence - Kept curl method implementation in uxarray/core/dataarray.py - Now have consolidated test_vector_calculus.py from main with gradient and divergence tests
erogluorhan
approved these changes
Oct 30, 2025
erogluorhan
left a comment
erogluorhan
left a comment
Member
There was a problem hiding this comment.
This looks great; thank you! Only thing I have to say is that can we come up with a simple visualization example for Curl and Divergence, maybe using the gradient data that gradient user guide used before?
Contributor
Author
How about in this PR make only one notebook |
Member
…nsolidated into Vector Calculus)
erogluorhan
reviewed
Nov 3, 2025
erogluorhan
reviewed
Nov 4, 2025
erogluorhan
reviewed
Nov 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #935. Closes #1300.