{{ message }}
Conversation
erogluorhan
reviewed
Sep 11, 2025
erogluorhan
left a comment
erogluorhan
left a comment
Member
There was a problem hiding this comment.
Great to see this coming in! Regarding the test file:
- How about waiting for PR #1349 to go first, so that we can use the reorg'ed test structure
- There is
test_inheritance.pythat tests forUxDataArrayfunctions inherited from xarray. Thus, how about creating data array and dataset classes in that one and putting tests here into the dataset class there, rather than creating a new file here?
Member
Author
rajeeja
approved these changes
Sep 12, 2025
rajeeja
left a comment
rajeeja
left a comment
Contributor
There was a problem hiding this comment.
Good work. Minor comment - add documentation UxDataset.isel() method
Member
Author
erogluorhan
approved these changes
Sep 12, 2025
erogluorhan
left a comment
erogluorhan
left a comment
Member
There was a problem hiding this comment.
Looks great; thanks for putting it together!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
UxDataset.isel()