Fix MPAS reader bug: Normalize after loading by rajeeja · Pull Request #1344 · UXARRAY/uxarray · GitHub
Skip to content

Fix MPAS reader bug: Normalize after loading#1344

Merged
philipc2 merged 8 commits into
mainfrom
rajeeja/mpas_normalization_fix
Aug 20, 2025
Merged

Fix MPAS reader bug: Normalize after loading#1344
philipc2 merged 8 commits into
mainfrom
rajeeja/mpas_normalization_fix

Conversation

@rajeeja

@rajeeja rajeeja commented Aug 14, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@rajeeja rajeeja requested a review from philipc2 August 14, 2025 17:11
@rajeeja

rajeeja commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

@philipc2 philipc2 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the face area be updated too?

@philipc2 philipc2 self-requested a review August 14, 2025 18:07
@rajeeja

rajeeja commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

Comment thread uxarray/io/_mpas.py Outdated
Comment thread test/test_mpas.py
Rajeev Jain and others added 3 commits August 18, 2025 10:10
@rajeeja rajeeja requested a review from philipc2 August 20, 2025 04:01

@philipc2 philipc2 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@philipc2 philipc2 merged commit 95fcfce into main Aug 20, 2025
20 checks passed
@erogluorhan erogluorhan deleted the rajeeja/mpas_normalization_fix branch September 26, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants