iframe-proxy

matz3 · 2026-06-29T18:19:11Z

JIRA: CPOUI5FOUNDATION-1275

d3xter666

LGTM

Tried different scenarios with file modifications, deleteions, new files and it seems to be working as expected

RandomByte

Some of these we could also tackle in a later follow-up. E.g. moving the implementation into the logger package (if we actually want to do that) is not a top priority for me and might come with extra work since we then need to account for multiple versions of the logger package being in use (which however is a good reason to couple the banner to the Serve-logger implementation)

JIRA: CPOUI5FOUNDATION-1275

matz3 · 2026-07-01T15:56:36Z

marianfoo · 2026-07-01T17:02:25Z

Just out of curiosity, what would happen if I use cap-plugin-ui5 and serve multiple UI5 Apps at the same time using CAP?
What I see in this PR I can only set output to silent to avoid this?

matz3 · 2026-07-02T07:14:09Z

Just out of curiosity, what would happen if I use cap-plugin-ui5 and serve multiple UI5 Apps at the same time using CAP? What I see in this PR I can only set output to silent to avoid this?

I would assume nothing would change. cap-plugin-ui5 does not seem to invoke the CLI via ui5 serve, so this feature won't be active.

codeworrior · 2026-07-02T08:08:21Z

I've tested it locally on a bigger project where I use the workspace feature of ui5 serve. The new banner reports the framework version of the project

UI5 CLI v5.0.0-alpha.5

❯ Local:   http://localhost:8080
❯ Network: use --accept-remote-connections to expose

Project   sapui5-dist-testsuite  (application)  v1.150.0-SNAPSHOT
Framework SAPUI5 1.150.0-SNAPSHOT

Status    ● ready    · Time elapsed: 14 s

but I get no indication that this doesn't match the workspace content. With the old log output, I saw the version of each project contained in the workspace sources:

info graph:helpers:ui5Framework Using SAPUI5 version: 1.150.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.core via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.layout via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.unified via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.codeeditor via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.dt via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.suite via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.m via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.table via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.commons via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ndc via local workspace to version 1.150.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.fl via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.mdc via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.tnt via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.ux3 via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.f via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.rta via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.support via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.integration via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.uxap via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.testrecorder via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project themelib_sap_belize via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project themelib_sap_fiori_3 via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project themelib_sap_horizon via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project themelib_sap_bluecrystal via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.webanalytics.core via local workspace to version 1.148.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.makit via local workspace to version 1.150.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.me via local workspace to version 1.150.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.export via local workspace to version 1.150.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.richtexteditor via local workspace to version 1.150.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.viz via local workspace to version 1.150.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.suite.ui.microchart via local workspace to version 1.150.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.vbm via local workspace to version 1.150.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ca.ui via local workspace to version 1.148.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.rules.ui via local workspace to version 1.148.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.vtm via local workspace to version 1.148.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.zen.commons via local workspace to version 1.150.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.zen.crosstab via local workspace to version 1.150.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.uiext.inbox via local workspace to version 1.150.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.sac.df via local workspace to version 1.150.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.documentation via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.chart via local workspace to version 1.150.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.insights via local workspace to version 1.150.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ca.scfld.md via local workspace to version 1.148.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.comp via local workspace to version 1.150.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.suite.ui.commons via local workspace to version 1.150.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.vk via local workspace to version 1.150.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.gantt via local workspace to version 1.150.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.generic.template via local workspace to version 1.148.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.collaboration via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ui.generic.app via local workspace to version 1.148.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ovp via local workspace to version 1.149.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.zen.dsh via local workspace to version 1.150.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.ushell via local workspace to version 1.151.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.apf via local workspace to version 1.148.0-SNAPSHOT
info graph:helpers:ui5Framework Resolved project sap.suite.ui.generic.template via local workspace to version 1.151.0-SNAPSHOT

As I appreciate the focused information presented by the banner, I would not like to always switch it off, just to see those inconsistencies. But I also don't want to hunt ghost bugs that in reality are unnoticed source inconsistencies.

Would it be possible to show an indicator for the inconsistencies, e.g. after the framework version, or is it too costly to determine this?

UI5 CLI v5.0.0-alpha.5

❯ Local:   http://localhost:8080
❯ Network: use --accept-remote-connections to expose

Project   sapui5-dist-testsuite  (application)  v1.150.0-SNAPSHOT
Framework SAPUI5 1.150.0-SNAPSHOT (not consistent with workspace content)

Status    ● ready    · Time elapsed: 14 s

matz3 · 2026-07-02T08:49:41Z

@codeworrior thank you for testing it and bringing this up! The downloading status of the framework packages is something I still wanted to add, but I didn't think about the workspaces. Would you prefer to only have such an inconsistency check, or would you like to be able to get back the full list of packages that are resolved via the workspace?

I feel like we might need an option to have a more verbose output in the banner, but far less compared to what --verbose prints. In the banner, we could try to include the most important information, such as the inconsistency warning, how many framework libs were resolved from the workspace (e.g. 9 of 10 projects resolved via workspace), etc., but without always listing everything.

As stated earlier, I would still like to merge this PR now, to unblock other work. I will address this in a follow-up PR.

codeworrior · 2026-07-02T09:00:44Z

RandomByte

As agreed, let's merge this as is and continue working on the mentioned points in follow-up PRs

matz3 requested a review from a team June 29, 2026 18:19

matz3 force-pushed the ui5-serve-console-output branch from 166413e to f4284bb Compare June 30, 2026 06:09

d3xter666 reviewed Jun 30, 2026

View reviewed changes

d3xter666 requested a review from a team June 30, 2026 12:02

RandomByte requested changes Jul 1, 2026

View reviewed changes

matz3 added 5 commits July 1, 2026 17:21

feat: Add live status banner to ui5 serve

25e217e

JIRA: CPOUI5FOUNDATION-1275

build: Update package-lock.json

a6a3643

test: Fix flaky tests

011841d

refactor: Handle direct stderr/stdout writes

8297afa

refactor: Apply feedback for rendering

c546338

matz3 force-pushed the ui5-serve-console-output branch from 4e310e6 to c546338 Compare July 1, 2026 15:21

matz3 added 2 commits July 1, 2026 17:38

refactor: Add TODO comment

9ace048

test: Fix tests, update lockfile

7eb46d0

matz3 requested a review from RandomByte July 1, 2026 15:56

matz3 added 2 commits July 1, 2026 18:00

refactor: Adjust text

6cde2ca

refactor: Fix figures tests on Windows

4b31b43

matz3 enabled auto-merge (squash) July 1, 2026 16:19

codeworrior reviewed Jul 2, 2026

View reviewed changes

Comment thread packages/cli/lib/serve/state.js Outdated

Comment thread packages/cli/lib/serve/state.js Outdated

refactor: Update outdated comment

610d68a

matz3 requested a review from codeworrior July 2, 2026 07:35

RandomByte approved these changes Jul 2, 2026

View reviewed changes

matz3 merged commit 2a46c8b into main Jul 2, 2026
60 checks passed

matz3 deleted the ui5-serve-console-output branch July 2, 2026 09:32

github-actions Bot mentioned this pull request Jul 2, 2026

release: UI5 CLI packages main #1433

Open

matz3 mentioned this pull request Jul 3, 2026

refactor: Move ui5 serve banner from cli to logger #1445

Open

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

matz3 commented Jun 29, 2026

Uh oh!

d3xter666 left a comment

Choose a reason for hiding this comment

Uh oh!

RandomByte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matz3 commented Jul 1, 2026

Uh oh!

marianfoo commented Jul 1, 2026

Uh oh!

matz3 commented Jul 2, 2026

Uh oh!

Uh oh!

Uh oh!

codeworrior commented Jul 2, 2026

Uh oh!

matz3 commented Jul 2, 2026

Uh oh!

codeworrior commented Jul 2, 2026

Uh oh!

RandomByte left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants