{{ message }}
Removing subprocess.#499
Closed
stelcheck wants to merge 1 commit into
Closed
Conversation
This commit: 1. Cleans up how the code is loaded 2. Removes the necessity to use 'spawn' Replaces TypeStrong#476 Replaces TypeStrong#489
This was referenced Dec 20, 2017
1 similar comment
Contributor
Author
|
One question: I expect that the way I extract flags from minimist that there could be collisions between userland flags and ts-node flags. |
Member
|
@stelcheck I think I'm missing something here. How are you using the node.js flags? |
Member
|
For reference, it seems like this is undoing #131? |
Contributor
Author
|
Right... I was thinking they would get applied, but you are right. I guess we have two options:
The first option would be tricky to implement properly I think, so I am trying to implement tjis without a wrapper. What is you take on it? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit:
Replaces #476
Replaces #489
Fixes #459
Fixes #471
Fixes #480
Fixes #487
Fixes #498
(phew - hope I don't forget anyone!)