Activity

1. lolleko

   changed the title [-]Restructuring strings is supported by TS but not by TSTL/Lua[/-] [+]Destructuring strings is supported by TS but not by TSTL/Lua[/+] on Apr 10, 2023
2. lolleko commented on Apr 10, 2023

   

   lolleko

   on Apr 10, 2023

   MemberAuthor

   More actions

   Related to #590
3. Perryvw commented on Apr 11, 2023

   

   Perryvw

   on Apr 11, 2023

   Member

   More actions

   What is the proposed output for your example:

   local __temp = foo()
   local a = temp[0]
   local b = temp[1]

   Something like this?
4. lolleko commented on Apr 11, 2023

   

   lolleko

   on Apr 11, 2023

   Last edited by lolleko

   MemberAuthor

   More actions

   Modern JS (don't know which standard maybe es5?) actually has built in support for string/iterator destructuring.

   For older JS targets TS transpiles to pretty much what you recommended. So we can probably get away with treating strings the same as arrays/tuples.

   👍React with 👍1Reacted by Perry van Wesel
5. Perryvw commented on Apr 11, 2023

   

   Perryvw

   on Apr 11, 2023

   Member

   More actions

   Come to think of it, indeed we should be able to use exactly the same code path as we use for arrays
6. Perryvw

   added

   enhancement

   scope: transformationTransformation of TS to LuaTransformation of TS to Lua

   on Apr 11, 2023
7. lolleko commented on Apr 11, 2023

   

   lolleko

   on Apr 11, 2023

   Last edited by lolleko

   MemberAuthor

   More actions

   Yes for literal variable declarations (and assignemnts), we can just treat them the same as array literals. However, for destructured assignment, we use table.unpack which wont work on string types.
8. lolleko

   linked a pull request that will close this issueString destructuring #1430on Apr 11, 2023