Fix addListener('insert/update/delete') events by 131 · Pull Request #1174 · TryGhost/node-sqlite3 · GitHub
Skip to content
This repository was archived by the owner on Jul 1, 2026. It is now read-only.

Fix addListener('insert/update/delete') events#1174

Closed
131 wants to merge 2 commits into
TryGhost:masterfrom
131:master
Closed

Fix addListener('insert/update/delete') events#1174
131 wants to merge 2 commits into
TryGhost:masterfrom
131:master

Conversation

@131

@131 131 commented Jun 5, 2019

Copy link
Copy Markdown

The `addListener('insert /update/delete') API throw

Error: update is not a valid configuration option
    at Database.addListener.Database.on (D:\dvp\study_stack\cloudfs\node_modules\sqlite3\lib\sqlite3.js:154:14)
    at SQLITE.on (D:\dvp\study_stack\cloudfs\libs\sql.js:74:15)
    at test.run (D:\dvp\study_stack\cloudfs\test.js:12:14)
    at <anonymous> Error: update is not a valid configuration option
    at Database.addListener.Database.on (D:\dvp\study_stack\cloudfs\node_modules\sqlite3\lib\sqlite3.js:154:14)
    at SQLITE.on (D:\dvp\study_stack\cloudfs\libs\sql.js:74:15)
    at test.run (D:\dvp\study_stack\cloudfs\test.js:12:14)
    at <anonymous>

The following adjustement in Database::Configure make it work !

@131

131 commented Jun 5, 2019

Copy link
Copy Markdown
Author

@kewde

kewde commented Jun 13, 2019

Copy link
Copy Markdown
Collaborator

Thank you for your pull request.
Additional tests and documentation are required for small changes to make sure that it works as intended.

@little-brother

little-brother commented Sep 26, 2019

Copy link
Copy Markdown

Any updates?

@soukand soukand mentioned this pull request Dec 25, 2019
Merged
@daniellockyer

daniellockyer commented Apr 30, 2022

Copy link
Copy Markdown
Contributor

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@131 @kewde @little-brother @daniellockyer