{{ message }}
Conversation
Adds a field and two new methods to WebSocketServer: setMaxPendingConnections(int) and getMaxPendingConnections() and uses the value as a parameter when binding the server socket.
Collaborator
Collaborator
|
I think there is no good way to test this right? |
Collaborator
Author
|
Well, the functionality is implemented in JDK, so it's their responsibility. The getter/setter logic in our code is trivial, so I think that there is no point in testing it. Theoretically we could prevent the server socket from accepting incoming sockets and see how many connections it takes to start dropping them, but then we would be simply testing JDK code. |
Collaborator
Author
|
If the only "breaking change" in 1.5.0 is a newer JDK version, then I agree about putting this in 1.5.0. |
marci4
approved these changes
Apr 22, 2020
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theoretically I should add this to 1.5.0 milestone, but since this is a non-breaking change and we also have a non-breaking #1000, so maybe there should be a small 1.4.2 release so that people can use these improvements without breaking changes of 1.5.0? I will add the appropriate @since tags to JavaDoc when this is decided.Description
Adds a field and two new methods to WebSocketServer:
setMaxPendingConnections(int)andgetMaxPendingConnections()and uses the value as a parameter when binding the server socket.Related Issue
Fixes #991
Motivation and Context
This change allows users to configure the maximum number of pending connections.
How Has This Been Tested?
Existing tests run fine.
Types of changes
Checklist: