{{ message }}
Repository navigation
Conversation
4ad1309 renamed the include list in run() to headers and changed the create_h_file() call in generate() to match, but generate() still receives that list as its testfile_includes parameter. Any run with :header_file or --header_file stops with a NameError after the runner has been written, leaving an empty header that the runner includes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🍍
On master, generating a runner with
:header_file(or--header_file=on the command line) stops with a NameError:The runner has already been written at that point and includes the header, which is left empty.
4ad1309 renamed the include list in
run()toheadersand changed thecreate_h_file()call ingenerate()to the new name, butgenerate()still receives the list as itstestfile_includesparameter. The call now passes that parameter again.The new
HeaderFileentry inRUNNER_TESTSgenerates a runner with:header_file, then builds and runs it like the other entries. 2.7.0 is not affected, so I did not add a changelog entry.