{{ message }}
Longest Consecutive Sequence LeetCode problem - #9686
Open
Sarthak950 wants to merge 20 commits into
Open
Sarthak950 wants to merge 20 commits into
Sarthak950 wants to merge 20 commits into
Conversation
chriso345
reviewed
Oct 4, 2023
removed the class from the solution Co-authored-by: Chris O <46587501+ChrisO345@users.noreply.github.com>
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
There was a problem hiding this comment.
An error occurred while parsing the file: data_structures/arrays/longest_consecutive_sequence.py
Traceback (most recent call last):
File "/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line 146, in parse
reports = lint_file(
^^^^^^^^^^
libcst._exceptions.ParserSyntaxError: Syntax Error @ 10:5.
parser error: error at 9:4: expected one of (, *, +, -, ..., AWAIT, EOF, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~
# Create a map of all numbers in the array to their index
^
algorithms-keeper
Bot
added
awaiting reviews
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
|
|
||
| def longestConsecutiveSequence(self, nums: List[int]) -> int: | ||
| # Create a map of all numbers in the array to their index |
There was a problem hiding this comment.
An error occurred while parsing the file: data_structures/arrays/longest_consecutive_sequence.py
Traceback (most recent call last):
File "/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line 146, in parse
reports = lint_file(
^^^^^^^^^^
libcst._exceptions.ParserSyntaxError: Syntax Error @ 10:5.
parser error: error at 9:4: expected one of (, *, +, -, ..., AWAIT, EOF, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~
# Create a map of all numbers in the array to their index
^
algorithms-keeper
Bot
added
the
require tests
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
| """ | ||
|
|
||
| def longestConsecutiveSequence(self, nums: List[int]) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/arrays/longest_consecutive_sequence.py, please provide doctest for the function longestConsecutiveSequence
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: longestConsecutiveSequence
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
|
|
||
|
|
||
| def longest_consecutive_sequence(self, nums: List[int]) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/arrays/longest_consecutive_sequence.py, please provide doctest for the function longest_consecutive_sequence
chriso345
requested changes
Oct 5, 2023
| """ | ||
|
|
||
|
|
||
| def longest_consecutive_sequence(self, nums: List[int]) -> int: |
Collaborator
There was a problem hiding this comment.
Please add doctests here; https://docs.python.org/3/library/doctest.html
chriso345
requested changes
Oct 5, 2023
| """ | ||
|
|
||
|
|
||
| def longest_consecutive_sequence(self, nums: List[int]) -> int: |
Collaborator
There was a problem hiding this comment.
Suggested change
| def longest_consecutive_sequence(self, nums: List[int]) -> int: | |
| def longest_consecutive_sequence(nums: list[int]) -> int: |
| Longest Consecutive Sequence Problem from LeetCode | ||
|
|
||
| """ | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| from collections import defaultdict | |
|
|
||
| 2. Then, we loop through the numbers, and for each number n, we check if it's already in seen list. | ||
| If so, we skip it. Otherwise, we start counting the length of the consecutive sequence starting from n. | ||
| This is done by checking if n+1 is in the dictionary. If so, we increment the counter, and set the seen status of n to 1. |
Collaborator
There was a problem hiding this comment.
Please make sure all lines are less than 88 characters long
algorithms-keeper
Bot
removed
the
require tests
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
| """ | ||
| //can u add | ||
| def longest_consecutive_sequence(nums): |
There was a problem hiding this comment.
An error occurred while parsing the file: data_structures/arrays/longest_consecutive_sequence.py
Traceback (most recent call last):
File "/opt/render/project/src/algorithms_keeper/parser/python_parser.py", line 146, in parse
reports = lint_file(
^^^^^^^^^^
libcst._exceptions.ParserSyntaxError: Syntax Error @ 8:3.
parser error: error at 7:2: expected one of (, *, +, -, ..., AWAIT, EOF, False, NAME, NUMBER, None, True, [, break, continue, lambda, match, not, pass, ~
def longest_consecutive_sequence(nums):
^for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
for more information, see https://pre-commit.ci
algorithms-keeper
Bot
added
the
require type hints
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| date: 4 OCT 2023 | ||
| Longest Consecutive Sequence Problem from LeetCode | ||
| """ | ||
| def longest_consecutive_sequence(nums): |
There was a problem hiding this comment.
Please provide return type hint for the function: longest_consecutive_sequence. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: nums
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| """ | ||
|
|
||
|
|
||
| def longest_consecutive_sequence(nums) -> int: |
There was a problem hiding this comment.
Please provide type hint for the parameter: nums
algorithms-keeper
Bot
removed
the
require type hints
for more information, see https://pre-commit.ci
chriso345
requested changes
Oct 5, 2023
Comment on lines
+10
to
+28
| """ | ||
| Finds the length of the longest consecutive sequence in a list of numbers. | ||
|
|
||
| Args: | ||
| nums (List[int]): A list of integers. | ||
|
|
||
| Returns: | ||
| int: The length of the longest consecutive sequence. | ||
|
|
||
| Examples: | ||
| >>> longest_consecutive_sequence([100, 4, 200, 1, 3, 2]) | ||
| 4 | ||
| >>> longest_consecutive_sequence([1, 2, 3, 4, 5]) | ||
| 5 | ||
| >>> longest_consecutive_sequence([5, 4, 3, 2, 1]) | ||
| 5 | ||
| >>> longest_consecutive_sequence([]) | ||
| 0 | ||
| """ |
Collaborator
There was a problem hiding this comment.
Suggested change
| """ | |
| Finds the length of the longest consecutive sequence in a list of numbers. | |
| Args: | |
| nums (List[int]): A list of integers. | |
| Returns: | |
| int: The length of the longest consecutive sequence. | |
| Examples: | |
| >>> longest_consecutive_sequence([100, 4, 200, 1, 3, 2]) | |
| 4 | |
| >>> longest_consecutive_sequence([1, 2, 3, 4, 5]) | |
| 5 | |
| >>> longest_consecutive_sequence([5, 4, 3, 2, 1]) | |
| 5 | |
| >>> longest_consecutive_sequence([]) | |
| 0 | |
| """ | |
| """ | |
| Finds the length of the longest consecutive sequence in a list of numbers. | |
| nums: A list of integers. | |
| int: The length of the longest consecutive sequence. | |
| >>> longest_consecutive_sequence([100, 4, 200, 1, 3, 2]) | |
| 4 | |
| >>> longest_consecutive_sequence([1, 2, 3, 4, 5]) | |
| 5 | |
| >>> longest_consecutive_sequence([5, 4, 3, 2, 1]) | |
| 5 | |
| >>> longest_consecutive_sequence([]) | |
| 0 | |
| """ |
Please read CONTRIBUTING.md to see how to indent docstrings.
| Finds the length of the longest consecutive sequence in a list of numbers. | ||
|
|
||
| Args: | ||
| nums (List[int]): A list of integers. |
Collaborator
There was a problem hiding this comment.
Please refrain from declaring types within a docstring.
for more information, see https://pre-commit.ci
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add a well documented solution with approach for the leet code problem Longest consecutive Sequence Leet code