Unmark fetch anime and play as BROKEN and fix type errors by CaedenPH · Pull Request #8988 · TheAlgorithms/Python · GitHub
Skip to content

Unmark fetch anime and play as BROKEN and fix type errors - #8988

Merged
tianyizheng02 merged 5 commits into
TheAlgorithms:masterfrom
CaedenPH:fetch-anime-and-play
Aug 18, 2023
Merged

Unmark fetch anime and play as BROKEN and fix type errors #8988
tianyizheng02 merged 5 commits into
TheAlgorithms:masterfrom
CaedenPH:fetch-anime-and-play

Conversation

@CaedenPH

@CaedenPH CaedenPH commented Aug 18, 2023

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@CaedenPH
CaedenPH requested a review from cclauss as a code owner August 18, 2023 12:05
@algorithms-keeper

algorithms-keeper Bot commented Aug 18, 2023

Copy link
Copy Markdown

@algorithms-keeper
algorithms-keeper Bot removed the request for review from cclauss August 18, 2023 12:05
@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Aug 18, 2023
@CaedenPH

CaedenPH commented Aug 18, 2023

Copy link
Copy Markdown
Contributor Author

@tianyizheng02 I can't create this pr because I have too many open, can you reopen please

@tianyizheng02 tianyizheng02 reopened this Aug 18, 2023
@algorithms-keeper algorithms-keeper Bot added the enhancement This PR modified some existing files label Aug 18, 2023
@tianyizheng02

tianyizheng02 commented Aug 18, 2023

Copy link
Copy Markdown
Contributor

tianyizheng02
tianyizheng02 approved these changes Aug 18, 2023
View reviewed changes

@tianyizheng02 tianyizheng02 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianyizheng02
tianyizheng02 merged commit 945803f into TheAlgorithms:master Aug 18, 2023
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Aug 18, 2023
@CaedenPH
CaedenPH deleted the fetch-anime-and-play branch August 18, 2023 12:22
This was referenced Aug 20, 2023
Closed
Merged
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tianyizheng02 tianyizheng02 tianyizheng02 approved these changes

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CaedenPH @tianyizheng02