{{ message }}
Problem 234 project Euler - #883
Merged
Merged
Conversation
cclauss
requested changes
Jun 8, 2019
cclauss
left a comment
cclauss
left a comment
Member
There was a problem hiding this comment.
Please change the filename so that it ends in .py.
Also, please add a comment at the top of the file that links to the problem statement:
# https://projecteuler.net/problem=234
eamanu
reviewed
Jun 8, 2019
Member
+1 |
Co-Authored-By: Emmanuel Arias <emmanuelarias30@gmail.com>
Co-Authored-By: Emmanuel Arias <emmanuelarias30@gmail.com>
Co-Authored-By: Emmanuel Arias <emmanuelarias30@gmail.com>
Co-Authored-By: Emmanuel Arias <emmanuelarias30@gmail.com>
Co-Authored-By: Emmanuel Arias <emmanuelarias30@gmail.com>
Co-Authored-By: Emmanuel Arias <emmanuelarias30@gmail.com>
cclauss
approved these changes
Jun 10, 2019
eamanu
approved these changes
Jun 10, 2019
eamanu
left a comment
eamanu
left a comment
There was a problem hiding this comment.
I left a comments. But I think this could be merge :-)
| return b | ||
| elif n==3: | ||
| return str(a)+str(b) | ||
| else: |
There was a problem hiding this comment.
I think this else could be ignore. Because never will be go to else if return occur before. (Just a comment)
and temp=0 could be defined after the ifs. This way we could avoid use memory when is not necessary.
Contributor
Author
|
Okay. Thank u for suggestions.
Regards
Archit H.
…On Tue, 11 Jun 2019, 4:47 am Emmanuel Arias, ***@***.***> wrote:
***@***.**** approved this pull request.
I left a comments. But I think this could be merge :-)
------------------------------
In project_euler/problem_234.py
<#883 (comment)>:
> @@ -0,0 +1,31 @@
+# https://projecteuler.net/problem=234
+def fib(a, b, n):
+ temp = 0
+ if n==1:
+ return a
+ elif n==2:
+ return b
+ elif n==3:
+ return str(a)+str(b)
+ else:
I think this else could be ignore. Because never will be go to else if
return occur before. (Just a comment)
and temp=0 could be defined after the ifs. This way we could avoid use
memory when is not necessary.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#883?email_source=notifications&email_token=AK6GTHFCH7Q2SQ23HD73N53PZ3OHZA5CNFSM4HVRSQSKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB3DHVBY#pullrequestreview-247888519>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AK6GTHE6VWF4JG6AKWQ6XO3PZ3OHZANCNFSM4HVRSQSA>
.
|
else was not required temp declared afterwards suggested changes are correct.Thank u!
eamanu
approved these changes
Jun 11, 2019
Contributor
Author
|
Are you going to merge it? |
poyea
approved these changes
Jun 16, 2019
poyea
left a comment
poyea
left a comment
Member
There was a problem hiding this comment.
Thank you for your pull request!🤩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.