New gitter link added or replaced by KaixLina · Pull Request #8551 · TheAlgorithms/Python · GitHub
Skip to content

New gitter link added or replaced - #8551

Merged
cclauss merged 9 commits into
TheAlgorithms:masterfrom
KaixLina:master
Mar 26, 2023
Merged

New gitter link added or replaced#8551
cclauss merged 9 commits into
TheAlgorithms:masterfrom
KaixLina:master

Conversation

@KaixLina

@KaixLina KaixLina commented Mar 26, 2023 •
edited by cclauss
Loading

Copy link
Copy Markdown
Contributor

Describe your change:

Fixes #8546

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Mar 26, 2023
@algorithms-keeper

algorithms-keeper Bot commented Mar 26, 2023

Copy link
Copy Markdown

@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Mar 26, 2023
@cclauss cclauss reopened this Mar 26, 2023
@algorithms-keeper algorithms-keeper Bot added documentation This PR modified documentation files tests are failing Do not merge until tests pass labels Mar 26, 2023
@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Mar 26, 2023
@cclauss cclauss changed the title New gitter link added or replaced ; New gitter link added or replaced Mar 26, 2023
@algorithms-keeper algorithms-keeper Bot removed the tests are failing Do not merge until tests pass label Mar 26, 2023
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Mar 26, 2023
@cclauss
cclauss merged commit 7cdb011 into TheAlgorithms:master Mar 26, 2023
@ChVeen

ChVeen commented Mar 26, 2023

Copy link
Copy Markdown
Contributor

Hi @KaixLina, you may have a look to PR #8546, I solved the issue already on my own, since after days no one did it... sorry.

@cclauss

cclauss commented Mar 26, 2023

Copy link
Copy Markdown
Member

tianyizheng02 pushed a commit to tianyizheng02/Python that referenced this pull request May 29, 2023
@KaixLina @cclauss @tianyizheng02
New gitter link added or replaced (TheAlgorithms#8551)
78dafd8 
* New gitter link added

* ruff==0.0.258

* noqa: S310

* noqa: S310

* Update ruff.yml

* Add Ruff rule S311

* Ruff v0.0.259

* return ("{:08x}" * 5).format(*self.h)

* pickle.load(f)  # noqa: S301

---------

Co-authored-by: Christian Clauss <cclauss@me.com>
@isidroas isidroas mentioned this pull request Jan 25, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

documentation This PR modified documentation files invalid

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KaixLina @ChVeen @cclauss