Raise error not string by CaedenPH · Pull Request #7945 · TheAlgorithms/Python · GitHub
Skip to content

Raise error not string - #7945

Merged
cclauss merged 15 commits into
TheAlgorithms:masterfrom
CaedenPH:raise-error-not-string
Nov 6, 2022
Merged

Raise error not string#7945
cclauss merged 15 commits into
TheAlgorithms:masterfrom
CaedenPH:raise-error-not-string

Conversation

@CaedenPH

@CaedenPH CaedenPH commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

Describe your change:

Replaces string errors with raising exceptions

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Nov 2, 2022
@CaedenPH

CaedenPH commented Nov 2, 2022

Copy link
Copy Markdown
Contributor Author

cclauss
cclauss reviewed Nov 2, 2022
View reviewed changes
Comment thread .flake8 Outdated
@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Nov 2, 2022
@CaedenPH

CaedenPH commented Nov 2, 2022

Copy link
Copy Markdown
Contributor Author

@cclauss The .flake8 change is from #7941

@CaedenPH

CaedenPH commented Nov 2, 2022

Copy link
Copy Markdown
Contributor Author

Fixing checks...

cclauss
cclauss reviewed Nov 2, 2022
View reviewed changes
Comment thread data_structures/binary_tree/segment_tree_other.py Outdated
@CaedenPH @cclauss
Update data_structures/binary_tree/segment_tree_other.py
d3b1f15 
Co-authored-by: Christian Clauss <cclauss@me.com>
@CaedenPH

CaedenPH commented Nov 2, 2022

Copy link
Copy Markdown
Contributor Author

@cclauss I'll apply that __repr__ structure to what I've changed so far

@CaedenPH

CaedenPH commented Nov 2, 2022

Copy link
Copy Markdown
Contributor Author

Pre-commit failed due to error mentioned in #7940 but build workflow is 👍

@algorithms-keeper algorithms-keeper Bot removed the tests are failing Do not merge until tests pass label Nov 2, 2022
cclauss
cclauss reviewed Nov 2, 2022
View reviewed changes
Comment thread data_structures/binary_tree/segment_tree_other.py Outdated
@CaedenPH @cclauss
Update data_structures/binary_tree/segment_tree_other.py
7025252 
Co-authored-by: Christian Clauss <cclauss@me.com>
@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Nov 2, 2022
@algorithms-keeper algorithms-keeper Bot removed the tests are failing Do not merge until tests pass label Nov 6, 2022
@CaedenPH

CaedenPH commented Nov 6, 2022

Copy link
Copy Markdown
Contributor Author

@cclauss I made the requested changes - pre-commit still failing due to the B023 error

cclauss
cclauss reviewed Nov 6, 2022
View reviewed changes
Comment thread genetic_algorithm/basic_string.py Outdated
@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Nov 6, 2022
@CaedenPH

CaedenPH commented Nov 6, 2022

Copy link
Copy Markdown
Contributor Author

@algorithms-keeper algorithms-keeper Bot removed the tests are failing Do not merge until tests pass label Nov 6, 2022
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Nov 6, 2022
@cclauss
cclauss merged commit daa1c75 into TheAlgorithms:master Nov 6, 2022
@CaedenPH
CaedenPH deleted the raise-error-not-string branch November 6, 2022 14:54
Cjkjvfnby pushed a commit to Cjkjvfnby/Python that referenced this pull request Mar 13, 2023
@CaedenPH @pre-commit-ci
@cclauss @Cjkjvfnby
Raise error not string (TheAlgorithms#7945)
fffd8f1 
* ci: Add `B023` to `.flake8` ignores

* refactor: Return `bool`/raise Exception

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* revert: Remove previous branch commit

* Update data_structures/binary_tree/segment_tree_other.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* feat: Apply `__repr__` changes

* chore: Fix failing tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update data_structures/binary_tree/segment_tree_other.py

Co-authored-by: Christian Clauss <cclauss@me.com>

* test: Fix doctests

* random.choice(population_score[:N_SELECTED])[0]

* Update basic_string.py

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes
@dhruvmanila dhruvmanila Awaiting requested review from dhruvmanila

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CaedenPH @cclauss