Added Builtin Voltage by sadiqebrahim · Pull Request #7850 · TheAlgorithms/Python · GitHub
Skip to content

Added Builtin Voltage - #7850

Merged
cclauss merged 9 commits into
TheAlgorithms:masterfrom
sadiqebrahim:master
Oct 30, 2022
Merged

Added Builtin Voltage#7850
cclauss merged 9 commits into
TheAlgorithms:masterfrom
sadiqebrahim:master

Conversation

@sadiqebrahim

@sadiqebrahim sadiqebrahim commented Oct 29, 2022

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Oct 29, 2022
CaedenPH
CaedenPH reviewed Oct 29, 2022
View reviewed changes

@CaedenPH CaedenPH left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - small changes to constants

Comment thread electronics/builtin_voltage.py Outdated
Comment thread electronics/builtin_voltage.py Outdated
sadiqebrahim and others added 4 commits October 29, 2022 21:55
@sadiqebrahim
Update builtin_voltage.py
736147b
@sadiqebrahim @CaedenPH
Update electronics/builtin_voltage.py
400dc60 
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
@sadiqebrahim @CaedenPH
Update electronics/builtin_voltage.py
4fa61ec 
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
1fb06aa 
for more information, see https://pre-commit.ci
@algorithms-keeper algorithms-keeper Bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 29, 2022
@sadiqebrahim
sadiqebrahim requested a review from CaedenPH October 29, 2022 16:34
CaedenPH
CaedenPH reviewed Oct 29, 2022
View reviewed changes

@CaedenPH CaedenPH left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake -

Comment thread electronics/builtin_voltage.py Outdated
Comment thread electronics/builtin_voltage.py Outdated
@sadiqebrahim @CaedenPH
Apply suggestions from code review
6655b04 
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
CaedenPH
CaedenPH approved these changes Oct 29, 2022
View reviewed changes

@CaedenPH CaedenPH left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cclauss Can you review pls

@cclauss cclauss added the ON HOLD: Final hours of Hacktoberfest We will review this PR after Hacktoberfest has ended label Oct 29, 2022
@algorithms-keeper algorithms-keeper Bot added the merge conflicts Open a new PR or rebase on the latest commit label Oct 30, 2022
@algorithms-keeper algorithms-keeper Bot removed the merge conflicts Open a new PR or rebase on the latest commit label Oct 30, 2022
cclauss
cclauss approved these changes Oct 30, 2022
View reviewed changes

@cclauss cclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes hashes/elf.py

@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Oct 30, 2022
@cclauss
cclauss merged commit 94b51f6 into TheAlgorithms:master Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes
@CaedenPH CaedenPH CaedenPH approved these changes

Assignees

No one assigned

Labels

ON HOLD: Final hours of Hacktoberfest We will review this PR after Hacktoberfest has ended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sadiqebrahim @cclauss @CaedenPH