{{ message }}
Format docs - #7821
Merged
Merged
Conversation
CaedenPH
reviewed
Oct 28, 2022
Contributor
Contributor
Author
Since we don't build documentation for that code we could leave it as is. 80% of these params/returns could be eliminated by annotations and good variable names. |
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
cclauss
approved these changes
Oct 29, 2022
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Describe your change:
Fix some warnings that would be raised by adding adding
flake8-docstringsto the pre-commit hooks.This PR is just to show the features of that tool.
There are two groups of checks.
Documentation
This looks like a good match with the repo guidelines. For classes and functions, there is an easy trick to use the leading underscore for names, then classes/functions won't be public, so you could document only what you need.
Docstring formating
It might be a bit confusing for people since the summary does not have a lot of sense in the context of this repo. It will have the same words as in the file and function names and algorithm description is in the module docstring. Ignoring that line is not an option since there is a lot of code with doctests.
Checklist:
Fixes: #{$ISSUE_NO}.