Added Manhattan distance algorithm by carlos3dx · Pull Request #7790 · TheAlgorithms/Python · GitHub
Skip to content

Added Manhattan distance algorithm - #7790

Merged
cclauss merged 6 commits into
TheAlgorithms:masterfrom
carlos3dx:add_manhattan_distance
Oct 30, 2022
Merged

Added Manhattan distance algorithm#7790
cclauss merged 6 commits into
TheAlgorithms:masterfrom
carlos3dx:add_manhattan_distance

Conversation

@carlos3dx

@carlos3dx carlos3dx commented Oct 28, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Describe your change:

Added an algorithm to calculate Manhattan distance,

Added the algorithm twice, one in a mor traditional way and other using a one-liner.

Fixes: #7776

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Oct 28, 2022
@rafagarciac
rafagarciac self-requested a review October 28, 2022 18:27
cclauss
cclauss reviewed Oct 28, 2022
View reviewed changes
Comment thread maths/manhattan_distance.py Outdated
cclauss
cclauss reviewed Oct 29, 2022
View reviewed changes
Comment thread maths/manhattan_distance.py Outdated
cclauss
cclauss reviewed Oct 30, 2022
View reviewed changes
Comment thread maths/manhattan_distance.py Outdated
@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Oct 30, 2022
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Oct 30, 2022
@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed and removed tests are failing Do not merge until tests pass labels Oct 30, 2022
@cclauss
cclauss merged commit 17d93ca into TheAlgorithms:master Oct 30, 2022
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Oct 30, 2022
@TheAlgorithms TheAlgorithms locked as resolved and limited conversation to collaborators Oct 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cclauss cclauss cclauss approved these changes
@rafagarciac rafagarciac Awaiting requested review from rafagarciac

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add the calculation of Manhattan Distance

2 participants

@carlos3dx @cclauss