Added Implementation of NAND, OR ,XNOR and NOT gates in python by karthiks2611 · Pull Request #7596 · TheAlgorithms/Python · GitHub
Skip to content

Added Implementation of NAND, OR ,XNOR and NOT gates in python - #7596

Merged
cclauss merged 17 commits into
TheAlgorithms:masterfrom
karthiks2611:master
Oct 25, 2022
Merged

Added Implementation of NAND, OR ,XNOR and NOT gates in python#7596
cclauss merged 17 commits into
TheAlgorithms:masterfrom
karthiks2611:master

Conversation

@karthiks2611

@karthiks2611 karthiks2611 commented Oct 24, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Oct 24, 2022
@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Oct 24, 2022
@algorithms-keeper algorithms-keeper Bot removed the tests are failing Do not merge until tests pass label Oct 24, 2022
@karthiks2611 karthiks2611 changed the title Added Implementation of NAND, OR and XNOR gates in python Added Implementation of NAND, OR ,XNOR and NOT gates in python Oct 24, 2022
arjitarora26
arjitarora26 reviewed Oct 24, 2022
View reviewed changes
Comment thread boolean_algebra/nand_gate.py Outdated

@arjitarora26 arjitarora26 Oct 24, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AND -> NAND

@karthiks2611 karthiks2611 Oct 24, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for pointing it out. Will do the corrections

arjitarora26
arjitarora26 reviewed Oct 24, 2022
View reviewed changes
Comment thread boolean_algebra/nand_gate.py Outdated
>>> nand_gate(1, 1)
0
"""
return int(not ((input_1, input_2).count(0) == 0))

@arjitarora26 arjitarora26 Oct 24, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can directly write
return int( (input_1, input_2).count(0) != 0)

@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Oct 24, 2022
@algorithms-keeper algorithms-keeper Bot removed the tests are failing Do not merge until tests pass label Oct 24, 2022
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Oct 25, 2022
@cclauss
cclauss merged commit 103c9e0 into TheAlgorithms:master Oct 25, 2022
@karthiks2611

karthiks2611 commented Oct 26, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Dear @cclauss,
I'm having doubts about whether this would be accepted for #Hacktoberfest.
Thanks for your comments and help. I really appreciate your time.
Let me know if everything works well.
Best,

@cclauss cclauss added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 26, 2022
@cclauss

cclauss commented Oct 26, 2022

Copy link
Copy Markdown
Member

This was referenced Oct 30, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes
+1 more reviewer
@arjitarora26 arjitarora26 arjitarora26 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@karthiks2611 @cclauss @arjitarora26