matrix/count_paths.py by deprecatedjd · Pull Request #7533 · TheAlgorithms/Python · GitHub
Skip to content

matrix/count_paths.py - #7533

Merged
chriso345 merged 11 commits into
TheAlgorithms:masterfrom
deprecatedjd:matrix
Oct 30, 2022
Merged

matrix/count_paths.py#7533
chriso345 merged 11 commits into
TheAlgorithms:masterfrom
deprecatedjd:matrix

Conversation

@deprecatedjd

@deprecatedjd deprecatedjd commented Oct 22, 2022

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Oct 22, 2022
chriso345
chriso345 requested changes Oct 23, 2022
View reviewed changes
Comment thread matrix/count_paths.py Outdated
Comment thread matrix/count_paths.py Outdated
deprecatedjd and others added 3 commits October 22, 2022 21:14
@deprecatedjd @chriso345
Update matrix/count_paths.py
4252ecb 
Co-authored-by: Chris O <46587501+ChrisO345@users.noreply.github.com>
@deprecatedjd @chriso345
Update matrix/count_paths.py
0209318 
Co-authored-by: Chris O <46587501+ChrisO345@users.noreply.github.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
e0ffc46 
for more information, see https://pre-commit.ci
@algorithms-keeper algorithms-keeper Bot added tests are failing Do not merge until tests pass and removed tests are failing Do not merge until tests pass labels Oct 23, 2022
@cclauss cclauss changed the title Matrix matrix/count_paths.py Oct 23, 2022
@cclauss
cclauss requested a review from chriso345 October 29, 2022 13:37
CaedenPH
CaedenPH reviewed Oct 29, 2022
View reviewed changes

@CaedenPH CaedenPH left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - small changes

Comment thread matrix/count_paths.py Outdated
Comment thread matrix/count_paths.py Outdated
Comment thread matrix/count_paths.py Outdated
chriso345
chriso345 reviewed Oct 30, 2022
View reviewed changes
Comment thread matrix/count_paths.py Outdated
@chriso345 @CaedenPH
Apply suggestions from code review
72891f9 
Co-authored-by: Caeden Perelli-Harris <caedenperelliharris@gmail.com>
@chriso345
chriso345 merged commit 7b7b3dd into TheAlgorithms:master Oct 30, 2022
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Oct 30, 2022
@chriso345 chriso345 added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CaedenPH CaedenPH CaedenPH left review comments
@chriso345 chriso345 chriso345 approved these changes

Assignees

No one assigned

Labels

hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@deprecatedjd @CaedenPH @chriso345