refactor: Make code more understandable by CaedenPH · Pull Request #7196 · TheAlgorithms/Python · GitHub
Skip to content

refactor: Make code more understandable - #7196

Merged
cclauss merged 2 commits into
TheAlgorithms:masterfrom
CaedenPH:binary-tree-fixes
Oct 14, 2022
Merged

cclauss merged 2 commits into
TheAlgorithms:masterfrom
CaedenPH:binary-tree-fixes

Conversation

@CaedenPH

@CaedenPH CaedenPH commented Oct 14, 2022

Copy link
Copy Markdown
Contributor

Describe your change:

Makes binary tree :meth:make_tree function more understandable.
Instead of

return Node(1, Node(2, Node(4), Node(5)), Node(3))

there is a visual example of the tree and the nodes are created manually without passing multiple parameters

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 14, 2022
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Oct 14, 2022
@cclauss
cclauss merged commit 2058775 into TheAlgorithms:master Oct 14, 2022
@cclauss cclauss added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 14, 2022
@CaedenPH
CaedenPH deleted the binary-tree-fixes branch October 14, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants