Add typing and snake casing to maths/decimal_isolate.py by saksham-chawla · Pull Request #7066 · TheAlgorithms/Python · GitHub
Skip to content

Add typing and snake casing to maths/decimal_isolate.py - #7066

Merged
cclauss merged 2 commits into
TheAlgorithms:masterfrom
saksham-chawla:patch-14
Oct 13, 2022
Merged

Add typing and snake casing to maths/decimal_isolate.py#7066
cclauss merged 2 commits into
TheAlgorithms:masterfrom
saksham-chawla:patch-14

Conversation

@saksham-chawla

@saksham-chawla saksham-chawla commented Oct 12, 2022

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper Bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 12, 2022
@saksham-chawla saksham-chawla mentioned this pull request Oct 13, 2022
Merged
14 tasks
@saksham-chawla

saksham-chawla commented Oct 13, 2022

Copy link
Copy Markdown
Contributor Author

@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Oct 13, 2022
@cclauss
cclauss merged commit 9b0909d into TheAlgorithms:master Oct 13, 2022
@saksham-chawla

saksham-chawla commented Oct 13, 2022

Copy link
Copy Markdown
Contributor Author

@cclauss cclauss added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes
@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees

No one assigned

Labels

enhancement This PR modified some existing files hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saksham-chawla @cclauss