Conversation
algorithms-keeper
Bot
added
require descriptive names
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
algorithms-keeper
Bot
removed
require descriptive names
for more information, see https://pre-commit.ci
kondekarshubham123
changed the title
Co-authored-by: Christian Clauss <cclauss@me.com>
Co-authored-by: Christian Clauss <cclauss@me.com>
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| right: TreeNode | None = None | ||
|
|
||
|
|
||
| def make_tree() -> TreeNode | None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function make_tree
| [3, 20, 7] | ||
| """ | ||
|
|
||
| def depth_first_search( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function depth_first_search
| [3, 9, 15] | ||
| """ | ||
|
|
||
| def depth_first_search( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function depth_first_search
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| right: TreeNode | None = None | ||
|
|
||
|
|
||
| def make_tree() -> TreeNode | None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function make_tree
| [3, 20, 7] | ||
| """ | ||
|
|
||
| def depth_first_search( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function depth_first_search
| [3, 9, 15] | ||
| """ | ||
|
|
||
| def depth_first_search( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function depth_first_search
algorithms-keeper
Bot
removed
the
tests are failing
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| right: TreeNode | None = None | ||
|
|
||
|
|
||
| def make_tree() -> TreeNode | None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function make_tree
| [3, 20, 7] | ||
| """ | ||
|
|
||
| def depth_first_search( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function depth_first_search
| [3, 9, 15] | ||
| """ | ||
|
|
||
| def depth_first_search( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function depth_first_search
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| [] | ||
| """ | ||
|
|
||
| def depth_first_search(root: TreeNode, depth: int, right_view: list[int]) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function depth_first_search
| [] | ||
| """ | ||
|
|
||
| def depth_first_search(root: TreeNode, depth: int, left_view: list[int]) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function depth_first_search
| [] | ||
| """ | ||
|
|
||
| def breadth_first_search(root: TreeNode, top_view: list[int]) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function breadth_first_search
| """ | ||
| from collections import defaultdict | ||
|
|
||
| def breadth_first_search(root: TreeNode, bottom_view: list[int]) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function breadth_first_search
algorithms-keeper
Bot
added
tests are failing
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| [] | ||
| """ | ||
|
|
||
| def depth_first_search(root: TreeNode, depth: int, right_view: list[int]) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function depth_first_search
| [] | ||
| """ | ||
|
|
||
| def depth_first_search(root: TreeNode, depth: int, left_view: list[int]) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function depth_first_search
| [] | ||
| """ | ||
|
|
||
| def breadth_first_search(root: TreeNode, top_view: list[int]) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function breadth_first_search
| """ | ||
| from collections import defaultdict | ||
|
|
||
| def breadth_first_search(root: TreeNode, bottom_view: list[int]) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function breadth_first_search
There was a problem hiding this comment.
@dhruvmanila doctests do not run on functions inside functions so the keeperbot should not expect to find them.
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| [] | ||
| """ | ||
|
|
||
| def depth_first_search(root: TreeNode, depth: int, right_view: list[int]) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function depth_first_search
| [] | ||
| """ | ||
|
|
||
| def depth_first_search(root: TreeNode, depth: int, left_view: list[int]) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function depth_first_search
| [] | ||
| """ | ||
|
|
||
| def breadth_first_search(root: TreeNode, top_view: list[int]) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function breadth_first_search
| """ | ||
| from collections import defaultdict | ||
|
|
||
| def breadth_first_search(root: TreeNode, bottom_view: list[int]) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function breadth_first_search
algorithms-keeper
Bot
removed
the
tests are failing
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| [] | ||
| """ | ||
|
|
||
| def depth_first_search(root: TreeNode | None, depth: int, right_view: list[int]) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function depth_first_search
| [] | ||
| """ | ||
|
|
||
| def depth_first_search(root: TreeNode | None, depth: int, left_view: list[int]) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function depth_first_search
| [] | ||
| """ | ||
|
|
||
| def breadth_first_search(root: TreeNode, top_view: list[int]) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function breadth_first_search
| """ | ||
| from collections import defaultdict | ||
|
|
||
| def breadth_first_search(root: TreeNode, bottom_view: list[int]) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function breadth_first_search
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| [] | ||
| """ | ||
|
|
||
| def depth_first_search( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function depth_first_search
| [] | ||
| """ | ||
|
|
||
| def depth_first_search( |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function depth_first_search
| [] | ||
| """ | ||
|
|
||
| def breadth_first_search(root: TreeNode, top_view: list[int]) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function breadth_first_search
| """ | ||
| from collections import defaultdict | ||
|
|
||
| def breadth_first_search(root: TreeNode, bottom_view: list[int]) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/binary_tree/diff_views_of_binary_tree.py, please provide doctest for the function breadth_first_search
algorithms-keeper
Bot
removed
the
awaiting reviews
cclauss
added
hacktoberfest
hacktoberfest-accepted
|
Hello sir, can u assign me this issue. I would love to grab this opportunity. |
4 participants
Describe your change:
Problem:
Given root of binary Tree, print the
Checklist:
Fixes: #{$ISSUE_NO}.