Adding ELFHash Algorithm - #6731
Conversation
Adding a new Hash Algorithm.
algorithms-keeper
Bot
added
awaiting reviews
![algorithms-keeper[bot]](https://avatars.githubusercontent.com/in/235834?s=60&v=4){kind=small}
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file hashes/elf.py, please provide doctest for the function ELFHash
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: ELFHash
Please provide return type hint for the function: ELFHash. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: data
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,12 @@ | |||
| def ELFHash(data): | |||
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file hashes/elf.py, please provide doctest for the function ELFHash
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: ELFHash
Please provide return type hint for the function: ELFHash. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: data
algorithms-keeper
Bot
removed
the
require tests
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,22 @@ | |||
| def elf_hash(data): | |||
There was a problem hiding this comment.
Please provide return type hint for the function: elf_hash. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: data
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,23 @@ | |||
| def elf_hash(data): | |||
There was a problem hiding this comment.
Please provide return type hint for the function: elf_hash. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: data
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,23 @@ | |||
| def elf_hash(data): | |||
There was a problem hiding this comment.
Please provide return type hint for the function: elf_hash. If the function does not return a value, please provide the type hint as: def function() -> None:
Please provide type hint for the parameter: data
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| @@ -0,0 +1,22 @@ | |||
| def elf_hash(data: str): | |||
There was a problem hiding this comment.
Please provide return type hint for the function: elf_hash. If the function does not return a value, please provide the type hint as: def function() -> None:
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
There was a problem hiding this comment.
Please provide return type hint for the function: elf_hash. If the function does not return a value, please provide the type hint as: def function() -> None:
algorithms-keeper
Bot
removed
the
require type hints
Co-authored-by: Caeden <caedenperelliharris@gmail.com>
algorithms-keeper
Bot
removed
the
awaiting reviews
3 participants
Adding a new Hash Algorithm.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.