Update astar.py by ahtesham007 · Pull Request #6456 · TheAlgorithms/Python · GitHub
Skip to content

Update astar.py - #6456

Merged
cclauss merged 4 commits into
TheAlgorithms:masterfrom
ahtesham007:master
Oct 2, 2022
Merged

Update astar.py#6456
cclauss merged 4 commits into
TheAlgorithms:masterfrom
ahtesham007:master

Conversation

@ahtesham007

@ahtesham007 ahtesham007 commented Oct 1, 2022

Copy link
Copy Markdown

Improved comments added punctuations.

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

AHTESHAM ZAIDI
Update astar.py
44eb9ba 
Improved comments added punctuations.
@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 1, 2022
CaedenPH
CaedenPH reviewed Oct 1, 2022
View reviewed changes
Comment thread machine_learning/astar.py Outdated
Comment thread machine_learning/astar.py

@CaedenPH CaedenPH Oct 1, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

cclauss and others added 3 commits October 2, 2022 23:40
@cclauss
Update astar.py
2b92cd7
@cclauss @CaedenPH
Update machine_learning/astar.py
0ef1cc5 
Co-authored-by: Caeden <caedenperelliharris@gmail.com>
@cclauss
Update astar.py
93f20d8
cclauss
cclauss approved these changes Oct 2, 2022
View reviewed changes

@cclauss cclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Oct 2, 2022
@cclauss
cclauss merged commit 707809b into TheAlgorithms:master Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CaedenPH CaedenPH CaedenPH left review comments
@cclauss cclauss cclauss approved these changes

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahtesham007 @cclauss @CaedenPH