Increased Readability Of Variables by ok-open-sc · Pull Request #6400 · TheAlgorithms/Python · GitHub
Skip to content

Increased Readability Of Variables - #6400

Merged
cclauss merged 5 commits into
TheAlgorithms:masterfrom
ok-open-sc:master
Oct 30, 2022
Merged

cclauss merged 5 commits into
TheAlgorithms:masterfrom
ok-open-sc:master

Conversation

@ok-open-sc

Copy link
Copy Markdown
Contributor

Describe your change:

Increased Readability Of Variables

Checklist:

  • [ Yes] I have read CONTRIBUTING.md.
  • [ Yes] This pull request is all my own work -- I have not plagiarized.
  • [ Yes] I know that pull requests will not be merged if they fail the automated tests.
  • [ Yes] This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • [ Yes] All new Python files are placed inside an existing directory.
  • [ Yes] All filenames are in all lowercase characters with no spaces or dashes.
  • [ Yes] All functions and variable names follow Python naming conventions.
  • [ Yes] All function parameters and return values are annotated with Python type hints.
  • [ Yes] All functions have doctests that pass the automated testing.
  • [ Yes] All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • [ Yes] If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@xijiehuayuan5

Copy link
Copy Markdown

Comment thread strings/anagrams.py Outdated
['final']
"""
return word_bysig[signature(my_word)]
return word_by_sig[signature(my_word)]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

What is your opinion on renaming word_by_sig to word_by_signature?

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Oct 30, 2022
@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Oct 30, 2022
@algorithms-keeper algorithms-keeper Bot removed the tests are failing Do not merge until tests pass label Oct 30, 2022
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Oct 30, 2022
@cclauss
cclauss merged commit 0c5f1c0 into TheAlgorithms:master Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants