feat: added ngram algorithm by 9harshit · Pull Request #6074 · TheAlgorithms/Python · GitHub
Skip to content

feat: added ngram algorithm - #6074

Merged
dhruvmanila merged 13 commits into
TheAlgorithms:masterfrom
9harshit:master
Apr 4, 2022
Merged

feat: added ngram algorithm#6074
dhruvmanila merged 13 commits into
TheAlgorithms:masterfrom
9harshit:master

Conversation

@9harshit

@9harshit 9harshit commented Mar 29, 2022

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed tests are failing Do not merge until tests pass labels Mar 29, 2022
@9harshit

9harshit commented Mar 29, 2022

Copy link
Copy Markdown
Contributor Author

@dhruvmanila

dhruvmanila commented Mar 30, 2022

Copy link
Copy Markdown
Member

cclauss
cclauss previously requested changes Mar 30, 2022
View reviewed changes
Comment thread strings/ngram.py Outdated
Comment thread arithmetic_analysis/in_static_equilibrium.py Outdated
@ghost ghost added awaiting changes A maintainer has requested changes to this PR and removed awaiting reviews This PR is ready to be reviewed labels Mar 30, 2022
@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Mar 30, 2022
cclauss
cclauss reviewed Mar 30, 2022
View reviewed changes
Comment thread strings/ngram.py Outdated
cclauss
cclauss reviewed Mar 30, 2022
View reviewed changes
Comment thread strings/ngram.py
9harshit and others added 2 commits March 30, 2022 20:20
@9harshit @cclauss
Update strings/ngram.py
2bf6ea8 
Co-authored-by: Christian Clauss <cclauss@me.com>
@9harshit @cclauss
Update strings/ngram.py
988fdda 
Co-authored-by: Christian Clauss <cclauss@me.com>
cclauss
cclauss reviewed Mar 31, 2022
View reviewed changes
Comment thread strings/ngram.py Outdated
@ghost ghost removed the tests are failing Do not merge until tests pass label Apr 4, 2022
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Apr 4, 2022
@dhruvmanila
dhruvmanila dismissed cclauss’s stale review April 4, 2022 03:35

Changes have been made.

@dhruvmanila
dhruvmanila merged commit 1f1daaf into TheAlgorithms:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss left review comments
@dhruvmanila dhruvmanila dhruvmanila approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@9harshit @dhruvmanila @cclauss