Improved prime_numbers.py by Leoriem-code · Pull Request #5592 · TheAlgorithms/Python · GitHub
Skip to content

Improved prime_numbers.py - #5592

Merged
cclauss merged 4 commits into
TheAlgorithms:masterfrom
Leoriem-code:improve-prime
Oct 26, 2021
Merged

Improved prime_numbers.py#5592
cclauss merged 4 commits into
TheAlgorithms:masterfrom
Leoriem-code:improve-prime

Conversation

@Leoriem-code

@Leoriem-code Leoriem-code commented Oct 25, 2021

Copy link
Copy Markdown
Contributor

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 25, 2021
@cclauss

cclauss commented Oct 25, 2021

Copy link
Copy Markdown
Member

@Leoriem-code

Leoriem-code commented Oct 26, 2021

Copy link
Copy Markdown
Contributor Author

I did around 80 000 test, and here are the results:
slow

normal

fast

@cclauss

cclauss commented Oct 26, 2021

Copy link
Copy Markdown
Member

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 26, 2021
@cclauss cclauss added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 26, 2021
@cclauss
cclauss merged commit 716beb3 into TheAlgorithms:master Oct 26, 2021
@Leoriem-code
Leoriem-code deleted the improve-prime branch October 26, 2021 08:01
@cclauss cclauss mentioned this pull request Oct 28, 2021
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes
@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees

No one assigned

Labels

enhancement This PR modified some existing files hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Leoriem-code @cclauss