[mypy] Fix type annotations for linked_stack.py by archaengel · Pull Request #5576 · TheAlgorithms/Python · GitHub
Skip to content

[mypy] Fix type annotations for linked_stack.py - #5576

Merged
cclauss merged 5 commits into
TheAlgorithms:masterfrom
archaengel:mypy-fix-stacks-linkedstack
Oct 31, 2021
Merged

[mypy] Fix type annotations for linked_stack.py#5576
cclauss merged 5 commits into
TheAlgorithms:masterfrom
archaengel:mypy-fix-stacks-linkedstack

Conversation

@archaengel

@archaengel archaengel commented Oct 24, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor 
$ mypy --ignore-missing-imports data_structures/stacks/linked_stack.py --strict
Success: no issues found in 1 source file

$ git checkout mypy-fix-stacks-linkedstack
Switched to branch 'mypy-fix-stacks-linkedstack'

$ mypy --ignore-missing-imports data_structures/stacks/linked_stack.py --strict
Success: no issues found in 1 source file

$ mypy --ignore-missing-imports data_structures/stacks --strict > after.txt

$ git checkout master
Switched to branch 'master'

$ mypy --ignore-missing-imports data_structures/stacks --strict > before.txt

$ diff before.txt after.txt
67,72d66
< data_structures/stacks/linked_stack.py:8: error: Function is missing a type annotation
< data_structures/stacks/linked_stack.py:12: error: Function is missing a return type annotation
< data_structures/stacks/linked_stack.py:49: error: Function is missing a return type annotation
< data_structures/stacks/linked_stack.py:55: error: Function is missing a return type annotation
< data_structures/stacks/linked_stack.py:66: error: Function is missing a return type annotation
< data_structures/stacks/linked_stack.py:99: error: Call to untyped function "Node" in typed context
85c79
< Found 82 errors in 12 files (checked 13 source files)
---
> Found 76 errors in 11 files (checked 13 source files)

Related to #4052

Describe your change:

Add generic type annotations for linked_stack.py.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Oct 24, 2021
@archaengel
archaengel force-pushed the mypy-fix-stacks-linkedstack branch from cd0b473 to 1316968 Compare October 24, 2021 07:17
poyea
poyea approved these changes Oct 25, 2021
View reviewed changes

@poyea poyea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request!🤩

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 25, 2021
@poyea poyea added the awaiting merge This PR is approved and ready to be merged label Oct 25, 2021
@archaengel

archaengel commented Oct 25, 2021

Copy link
Copy Markdown
Contributor Author

cclauss
cclauss requested changes Oct 26, 2021
View reviewed changes
Comment thread data_structures/stacks/linked_stack.py Outdated
Comment thread data_structures/stacks/linked_stack.py Outdated
@ghost ghost added awaiting changes A maintainer has requested changes to this PR and removed awaiting merge This PR is approved and ready to be merged labels Oct 26, 2021
@poyea

poyea commented Oct 26, 2021

Copy link
Copy Markdown
Member

ref: https://www.python.org/dev/peps/pep-0604/

@ghost ghost added awaiting reviews This PR is ready to be reviewed and removed awaiting changes A maintainer has requested changes to this PR labels Oct 26, 2021
@poyea

poyea commented Oct 26, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

So I guess #5577 is a doubly linked list implementation and this is a singly linked list implementation. How about we change #5577 to stack_with_doubly_linked_list.py and this to stack_with_singly_linked_list.py. Because when we generate directory, dll is not so helpful

@archaengel

archaengel commented Oct 27, 2021

Copy link
Copy Markdown
Contributor Author

I think that makes sense. Should I open up a new PR for the rename or include those changes in with this one?

@poyea

poyea commented Oct 27, 2021

Copy link
Copy Markdown
Member

You can just make the changes here @archaengel

@archaengel
archaengel force-pushed the mypy-fix-stacks-linkedstack branch from 05b5dab to 7141bc4 Compare October 27, 2021 03:59
@ghost ghost added the merge conflicts Open a new PR or rebase on the latest commit label Oct 27, 2021
@archaengel
archaengel force-pushed the mypy-fix-stacks-linkedstack branch from 94a38a7 to 8e6fdae Compare October 27, 2021 04:05
@ghost ghost removed the merge conflicts Open a new PR or rebase on the latest commit label Oct 27, 2021
@archaengel

archaengel commented Oct 27, 2021

Copy link
Copy Markdown
Contributor Author

Sgtm, done.

@archaengel

archaengel commented Oct 31, 2021

Copy link
Copy Markdown
Contributor Author

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 31, 2021
@cclauss
cclauss merged commit 94f38dd into TheAlgorithms:master Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes
@poyea poyea poyea approved these changes

Assignees

No one assigned

Labels

enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@archaengel @poyea @cclauss