[mypy] Fix type annotations in `lowest_common_ancestor.py` by dylanbuchi · Pull Request #5574 · TheAlgorithms/Python · GitHub
Skip to content

[mypy] Fix type annotations in lowest_common_ancestor.py - #5574

Closed
dylanbuchi wants to merge 1 commit into
TheAlgorithms:masterfrom
dylanbuchi:mypy-fix-lowest-common-ancestor
Closed

[mypy] Fix type annotations in lowest_common_ancestor.py#5574
dylanbuchi wants to merge 1 commit into
TheAlgorithms:masterfrom
dylanbuchi:mypy-fix-lowest-common-ancestor

Conversation

@dylanbuchi

@dylanbuchi dylanbuchi commented Oct 24, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Describe your change:

[mypy] Fix type annotations in data_structures/binary_tree/lowest_common_ancestor.py #4052

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added the awaiting reviews This PR is ready to be reviewed label Oct 24, 2021
@ghost

ghost commented Oct 24, 2021

Copy link
Copy Markdown

@ghost ghost closed this Oct 24, 2021
@dylanbuchi
dylanbuchi deleted the mypy-fix-lowest-common-ancestor branch October 24, 2021 00:12
@dylanbuchi
dylanbuchi restored the mypy-fix-lowest-common-ancestor branch October 24, 2021 00:12
@dylanbuchi
dylanbuchi deleted the mypy-fix-lowest-common-ancestor branch November 3, 2021 09:54
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dylanbuchi