{{ message }}
Add solution for Project Euler problem 67 - #5519
Merged
Merged
Conversation
A faster and memory efficient solution based on the template of sol1.py. Modified the solution to be more memory efficient while reading and generating the array and during the solution finding. No conditions and straightforward logic.
ghost
added
awaiting reviews
ghost
reviewed
Oct 22, 2021
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
ghost
removed
the
require type hints
franciscoperez2021
approved these changes
Oct 24, 2021
franciscoperez2021
left a comment
franciscoperez2021
left a comment
Contributor
There was a problem hiding this comment.
It looks good to me as I have tested locally comparing solutions with sol1.py as well as I have tested with different triangles.txt files
Contributor
Author
Contributor
Author
|
@cclauss @franciscoperez2021 can you please look this? Thanks |
cclauss
reviewed
Oct 25, 2021
Preferring comprehensions over map Co-authored-by: Christian Clauss <cclauss@me.com>
Contributor
Author
Can I please get any other reviewers @cclauss @franciscoperez2021 ? Thanks |
poyea
reviewed
Oct 28, 2021
cclauss
requested changes
Oct 28, 2021
ghost
added
awaiting changes
Self explanatory variable names
ghost
added
awaiting reviews
cclauss
requested changes
Oct 28, 2021
ghost
added
awaiting changes
Co-authored-by: Christian Clauss <cclauss@me.com>
ghost
added
awaiting reviews
Co-authored-by: Christian Clauss <cclauss@me.com>
Contributor
Author
cclauss
approved these changes
Oct 28, 2021
poyea
approved these changes
Oct 28, 2021
poyea
left a comment
poyea
left a comment
Member
There was a problem hiding this comment.
Thank you for your pull request!🤩
poyea
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A faster and memory efficient solution based on the template of sol1.py.
Modified the solution to be more memory efficient while reading and generating the array
and during the solution finding.
No conditions and straightforward logic.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.