Add doctests to prime_check function by murilo-goncalves · Pull Request #5503 · TheAlgorithms/Python · GitHub
Skip to content

Add doctests to prime_check function - #5503

Merged
poyea merged 2 commits into
TheAlgorithms:masterfrom
murilo-goncalves:test/prime_check
Oct 22, 2021
Merged

poyea merged 2 commits into
TheAlgorithms:masterfrom
murilo-goncalves:test/prime_check

Conversation

@murilo-goncalves

Copy link
Copy Markdown
Contributor

Describe your change:

Add doctests to prime_check function in maths/prime_check.py as discussed in #5488

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files tests are failing Do not merge until tests pass labels Oct 21, 2021
@ghost ghost removed the tests are failing Do not merge until tests pass label Oct 21, 2021
Comment thread maths/prime_check.py
Comment thread maths/prime_check.py

@cclauss cclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Oct 22, 2021
@poyea
poyea merged commit 07141e4 into TheAlgorithms:master Oct 22, 2021
@murilo-goncalves
murilo-goncalves deleted the test/prime_check branch October 22, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants